From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
Takashi Iwai <tiwai@suse.de>,
"Lin, Mengdong" <mengdong.lin@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Wang Xingchao <xingchao.wang@linux.intel.com>,
"Li, Jocelyn" <jocelyn.li@intel.com>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>,
"david.henningsson@canonical.com"
<david.henningsson@canonical.com>
Subject: Re: [RFC PATCH 1/3] drm/915: Add private api for power well usage
Date: Thu, 9 May 2013 11:53:15 -0700 [thread overview]
Message-ID: <20130509115315.601598f6@jbarnes-desktop> (raw)
In-Reply-To: <20130509113001.7e7ff1d6@jbarnes-desktop>
On Thu, 9 May 2013 11:30:01 -0700
Jesse Barnes <jesse.barnes@intel.com> wrote:
> > The question is in which level we need power_well_*() controls.
> > If the initialization of HD-audio controller (e.g. PCI registers)
> > requires the power well on, hda_intel.c requires the calls, as this
> > patch does. OTOH, if it's only about the HD-audio verbs, basically we
> > can push the power well calls into the codec driver,
> > i.e. patch_hdmi.c. In the latter case, as David once suggested, we
> > can split the Haswell codec driver from patch_hdmi.c so that only the
> > new driver depends on i915.
>
> I think it's needed for the HDMI related MMIO regs as well, but I don't
> have a platform to test and make sure.
Sorry, HD regs, not HDMI (though the power well is needed for those
too :). AFAIK all the registers for interacting with HDMI audio on the
graphics device require the power well to be up in order to be accessed.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-05-09 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368082842-2537-1-git-send-email-xingchao.wang@linux.intel.com>
[not found] ` <46B810F6945F7C4788E11DCE57EC489010E584A7@SHSMSX102.ccr.corp.intel.com>
2013-05-09 9:23 ` [RFC PATCH 1/3] drm/915: Add private api for power well usage Daniel Vetter
2013-05-09 9:58 ` Wang, Xingchao
2013-05-09 17:17 ` Takashi Iwai
2013-05-09 18:30 ` Jesse Barnes
2013-05-09 18:53 ` Jesse Barnes [this message]
2013-05-10 5:02 ` Wang, Xingchao
2013-05-10 4:47 ` Wang, Xingchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509115315.601598f6@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jesse.barnes@intel.com \
--cc=jocelyn.li@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=tiwai@suse.de \
--cc=xingchao.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.