From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC][PATCH 1/1] drm/i915: Rewrite ILK+ watermark handling
Date: Thu, 9 May 2013 12:09:30 -0700 [thread overview]
Message-ID: <20130509120930.49a7ba41@jbarnes-desktop> (raw)
In-Reply-To: <1367847952-1096-2-git-send-email-ville.syrjala@linux.intel.com>
On Mon, 6 May 2013 16:45:52 +0300
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Rewrite the ILK+ watermark code to allow:
> - updating the watermarks safely (to avoid underruns)
> - pre-computing watermarks (will help with atomic modest and pageflip)
> - enabling LP1+ watermarks for HSW multi-pipe scenarios
This looks like the right way to go long term. But Paulo's patches for
HSW are fairly small and make things better immediately, so we should
probably get them in first.
This one needs to be split up somehow so we can review it better like
you mention in the TODO.
Another thing that I used when doing the WM code way back when was to
port it to userspace and run through various configs to make sure the
values were all sane. Might be nice if we could do that easily
somehow, maybe with an #ifdef or putting all the wm stuff into a
separate file.
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-05-09 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 13:45 [RFC][PATCH 0/1] drm/i915: Big watermark changes ville.syrjala
2013-05-06 13:45 ` [RFC][PATCH 1/1] drm/i915: Rewrite ILK+ watermark handling ville.syrjala
2013-05-07 19:55 ` Paulo Zanoni
2013-05-09 19:09 ` Jesse Barnes [this message]
2013-05-10 7:14 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509120930.49a7ba41@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.