Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

From: Igor Mammedov <imammedo@redhat.com>
To: Chegu Vinod <chegu_vinod@hp.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com,
	anthony@codemonkey.ws, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration
Date: Thu, 9 May 2013 22:05:37 +0200	[thread overview]
Message-ID: <20130509220537.3018a727@thinkpad> (raw)
In-Reply-To: <1368128600-30721-4-git-send-email-chegu_vinod@hp.com>

On Thu,  9 May 2013 12:43:20 -0700
Chegu Vinod <chegu_vinod@hp.com> wrote:

>  If a user chooses to turn on the auto-converge migration capability
>  these changes detect the lack of convergence and throttle down the
>  guest. i.e. force the VCPUs out of the guest for some duration
>  and let the migration thread catchup and help converge.
> 
[...]
> +void migration_throttle_down(void)
> +{
> +    if (throttling_needed()) {
> +        CPUArchState *penv = first_cpu;
> +        while (penv) {
> +            qemu_mutex_lock_iothread();
> +            async_run_on_cpu(ENV_GET_CPU(penv), mig_kick_cpu, NULL);
> +            qemu_mutex_unlock_iothread();
> +            penv = penv->next_cpu;
could you replace open coded loop with qemu_for_each_cpu()?

> +        }
> +    }
> +}

-- 
Regards,
  Igor