From: Al Viro <viro@ZenIV.linux.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Kent Overstreet <koverstreet@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus <torvalds@linux-foundation.org>
Subject: Re: linux-next: build warning after merge of the origintree
Date: Fri, 10 May 2013 05:51:44 +0100 [thread overview]
Message-ID: <20130510045144.GJ25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130510131926.bbbee7dec35f696c407ac63e@canb.auug.org.au>
On Fri, May 10, 2013 at 01:19:26PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the akpm tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/md/bcache/super.c:656:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/md/bcache/super.c:656:2: warning: (near initialization for 'bcache_ops.release') [enabled by default]
>
> Introduced by commit cafe56359144 ("bcache: A block layer cache")
> interacting with commit db2a144bedd5 ("block_device_operations->release()
> should return void").
Simply drop that return 0; and make it return void. Or just leave it as is
for now - while C implementation has every right to blow up when calling a
function that returns int as if it had been a function returning void (e.g.
C ABI might have return value for int passed as it's usually done for big
structs), AFAIK, none of the architectures we support do anything of that
kind.
prev parent reply other threads:[~2013-05-10 4:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 3:19 linux-next: build warning after merge of the origintree Stephen Rothwell
2013-05-10 4:51 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510045144.GJ25399@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.