From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Tue, 14 May 2013 18:32:08 +0200
Subject: [U-Boot] [PATCH v2 4/4] arm: factorize relocate_code routine
In-Reply-To: <1489195069.818131.1368547310358.JavaMail.root@advansee.com>
References: <1368223012-17609-1-git-send-email-albert.u.boot@aribaud.net>
	<1368525030-5162-1-git-send-email-albert.u.boot@aribaud.net>
	<1368525030-5162-2-git-send-email-albert.u.boot@aribaud.net>
	<1368525030-5162-3-git-send-email-albert.u.boot@aribaud.net>
	<1368525030-5162-4-git-send-email-albert.u.boot@aribaud.net>
	<1368525030-5162-5-git-send-email-albert.u.boot@aribaud.net>
	<1489195069.818131.1368547310358.JavaMail.root@advansee.com>
Message-ID: <20130514183208.7075bd24@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Beno?t,

On Tue, 14 May 2013 18:01:50 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert,

> >  	.globl	c_runtime_cpu_setup
> >  c_runtime_cpu_setup:
> >  
> > -	bx	lr
> > +	/*
> > +	 * Unlock (actually, disable) the cache now that board_init_f
> > +	 * is done. We could do this earlier but we would need to add
> > +	 * a new C runtime hook, whereas c_runtime_cpu_setup already
> > +	 * exists.
> > +	 * As this routine is just a call to cpu_init_crit, let us
> > +	 * tail-optimize and do a simple branch here.
> > +	 */
> > +	b	cpu_init_crit
> 
> Shouldn't the "#ifdef CONFIG_CPU_PXA25X" from the original code be kept here?

Yes, it should indeed. Thanks for spotting this!

> Best regards,
> Beno?t

Amicalement,
-- 
Albert.