From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it Date: Thu, 16 May 2013 07:53:55 +0100 Message-ID: <20130516065355.GA3269@gmail.com> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-13-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Felipe Balbi , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "David S. Miller" , Herbert Xu , Vinod Koul , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Andreas Westin To: Linus Walleij Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Wed, 15 May 2013, Linus Walleij wrote: > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wr= ote: >=20 > > If we fail to prepare the ux500-hash clock before enabling it the > > platform will fail to boot. Here we insure this happens. > > > > Cc: Herbert Xu > > Cc: David S. Miller > > Cc: Andreas Westin > > Cc: linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Acked-by: Arnd Bergmann > > Acked-by: Ulf Hansson > > Signed-off-by: Lee Jones >=20 > This patch seems to be totally independent of the other stuff > in the patch series, and it even seems like an -rc fix to me > (I don't think the crypto device works without this). >=20 > This should go into the crypto tree? I agree.=20 > Else please convince Herbert to give his ACK on this > before I apply it. Pleeeeaasseee Herbert, take this patch! :) How's that? --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755489Ab3EPGyF (ORCPT ); Thu, 16 May 2013 02:54:05 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:64343 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755057Ab3EPGyD (ORCPT ); Thu, 16 May 2013 02:54:03 -0400 Date: Thu, 16 May 2013 07:53:55 +0100 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Felipe Balbi , "linux-usb@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "David S. Miller" , Herbert Xu , Vinod Koul , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Andreas Westin Subject: Re: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it Message-ID: <20130516065355.GA3269@gmail.com> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-13-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 May 2013, Linus Walleij wrote: > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > > > If we fail to prepare the ux500-hash clock before enabling it the > > platform will fail to boot. Here we insure this happens. > > > > Cc: Herbert Xu > > Cc: David S. Miller > > Cc: Andreas Westin > > Cc: linux-crypto@vger.kernel.org > > Acked-by: Arnd Bergmann > > Acked-by: Ulf Hansson > > Signed-off-by: Lee Jones > > This patch seems to be totally independent of the other stuff > in the patch series, and it even seems like an -rc fix to me > (I don't think the crypto device works without this). > > This should go into the crypto tree? I agree. > Else please convince Herbert to give his ACK on this > before I apply it. Pleeeeaasseee Herbert, take this patch! :) How's that? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 16 May 2013 07:53:55 +0100 Subject: [PATCH 12/39] crypto: ux500/hash - Prepare clock before enabling it In-Reply-To: References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-13-git-send-email-lee.jones@linaro.org> Message-ID: <20130516065355.GA3269@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 15 May 2013, Linus Walleij wrote: > On Wed, May 15, 2013 at 11:51 AM, Lee Jones wrote: > > > If we fail to prepare the ux500-hash clock before enabling it the > > platform will fail to boot. Here we insure this happens. > > > > Cc: Herbert Xu > > Cc: David S. Miller > > Cc: Andreas Westin > > Cc: linux-crypto at vger.kernel.org > > Acked-by: Arnd Bergmann > > Acked-by: Ulf Hansson > > Signed-off-by: Lee Jones > > This patch seems to be totally independent of the other stuff > in the patch series, and it even seems like an -rc fix to me > (I don't think the crypto device works without this). > > This should go into the crypto tree? I agree. > Else please convince Herbert to give his ACK on this > before I apply it. Pleeeeaasseee Herbert, take this patch! :) How's that? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog