From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() Date: Thu, 16 May 2013 15:01:57 +0800 Message-ID: <20130516070157.GC6721@gondor.apana.org.au> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-17-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com, linux-usb@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, vinod.koul@intel.com, arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Andreas Westin To: Lee Jones Return-path: Content-Disposition: inline In-Reply-To: <1368611522-9984-17-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, May 15, 2013 at 10:51:39AM +0100, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Acked-by: Linus Walleij > Signed-off-by: Lee Jones Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755529Ab3EPHCH (ORCPT ); Thu, 16 May 2013 03:02:07 -0400 Received: from ringil.hengli.com.au ([178.18.16.133]:36880 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754949Ab3EPHCE (ORCPT ); Thu, 16 May 2013 03:02:04 -0400 Date: Thu, 16 May 2013 15:01:57 +0800 From: Herbert Xu To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com, linux-usb@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, vinod.koul@intel.com, arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Andreas Westin Subject: Re: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() Message-ID: <20130516070157.GC6721@gondor.apana.org.au> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-17-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368611522-9984-17-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2013 at 10:51:39AM +0100, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Acked-by: Arnd Bergmann > Acked-by: Linus Walleij > Signed-off-by: Lee Jones Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 From: herbert@gondor.apana.org.au (Herbert Xu) Date: Thu, 16 May 2013 15:01:57 +0800 Subject: [PATCH 16/39] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() In-Reply-To: <1368611522-9984-17-git-send-email-lee.jones@linaro.org> References: <1368611522-9984-1-git-send-email-lee.jones@linaro.org> <1368611522-9984-17-git-send-email-lee.jones@linaro.org> Message-ID: <20130516070157.GC6721@gondor.apana.org.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 15, 2013 at 10:51:39AM +0100, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto at vger.kernel.org > Acked-by: Arnd Bergmann > Acked-by: Linus Walleij > Signed-off-by: Lee Jones Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt