From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756438Ab3EQRXu (ORCPT ); Fri, 17 May 2013 13:23:50 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:51273 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756245Ab3EQRXt (ORCPT ); Fri, 17 May 2013 13:23:49 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/onTMTfja8cSlXmgugWq3Q Date: Fri, 17 May 2013 10:23:35 -0700 From: Tony Lindgren To: Kishon Vijay Abraham I Cc: Tomi Valkeinen , linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy Message-ID: <20130517172335.GX5600@atomide.com> References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> <519503DA.5070303@iki.fi> <20130516162034.GX5600@atomide.com> <5195C28C.40300@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5195C28C.40300@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kishon Vijay Abraham I [130516 22:45]: > Hi, > > On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: > >* Tomi Valkeinen [130516 09:11]: > >>On 16/05/13 18:58, Tony Lindgren wrote: > >>>* Tomi Valkeinen [130515 03:59]: > >>> > >>>Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds > >>>like the some transceivers should depend on that for omap4. > >> > >>Yes, I have OCP2SCP=y. > > > >Hmm well no idea beyond that then. Sounds like Kishon should check it. > > > >>>>The musb-hdrc id is wrong on overo also. > >>> > >>>Hmm has there been a fix posted for that? > >> > >>I couldn't find with a quick look. We debugged and discussed this on an irc > >>channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID > >>on overo fixed the issue, and it looks very similar to the error on 4430sdp. > >>The overo fix was just: > > hmm.. I think using device name to bind the controller and the phy > can no longer be used reliably. I think it's better to have > something like what Grant suggested in my other patch series.. to > have the phy reference into the host controllers platform_data > structure. And for the phy reference I'll have label and id. > > Does this makes sense to you? Sounds OK to me, but I guess that would be for v3.11. I think we still need a fix for at least overo for v3.10? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 17 May 2013 10:23:35 -0700 Subject: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy In-Reply-To: <5195C28C.40300@ti.com> References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> <519503DA.5070303@iki.fi> <20130516162034.GX5600@atomide.com> <5195C28C.40300@ti.com> Message-ID: <20130517172335.GX5600@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Kishon Vijay Abraham I [130516 22:45]: > Hi, > > On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: > >* Tomi Valkeinen [130516 09:11]: > >>On 16/05/13 18:58, Tony Lindgren wrote: > >>>* Tomi Valkeinen [130515 03:59]: > >>> > >>>Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds > >>>like the some transceivers should depend on that for omap4. > >> > >>Yes, I have OCP2SCP=y. > > > >Hmm well no idea beyond that then. Sounds like Kishon should check it. > > > >>>>The musb-hdrc id is wrong on overo also. > >>> > >>>Hmm has there been a fix posted for that? > >> > >>I couldn't find with a quick look. We debugged and discussed this on an irc > >>channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID > >>on overo fixed the issue, and it looks very similar to the error on 4430sdp. > >>The overo fix was just: > > hmm.. I think using device name to bind the controller and the phy > can no longer be used reliably. I think it's better to have > something like what Grant suggested in my other patch series.. to > have the phy reference into the host controllers platform_data > structure. And for the phy reference I'll have label and id. > > Does this makes sense to you? Sounds OK to me, but I guess that would be for v3.11. I think we still need a fix for at least overo for v3.10? Regards, Tony