From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/9] drm/i915: use the mode->htotal to calculate linetime watermarks Date: Mon, 20 May 2013 16:42:48 +0300 Message-ID: <20130520134248.GF14974@intel.com> References: <1367612625-4823-1-git-send-email-przanoni@gmail.com> <1367612625-4823-4-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CAA92E5DD7 for ; Mon, 20 May 2013 06:42:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367612625-4823-4-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, May 03, 2013 at 05:23:39PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > = > ... instead of mode->crtc_display. The spec says "pipe horizontal > total number of pixels" and the "Haswell Watermark Calculator" tool > uses the "Pipe H Total" instead of "Pipe H Src" as the value. > = > Signed-off-by: Paulo Zanoni Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index d056bc9..4cc5f99 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -2035,7 +2035,7 @@ haswell_update_linetime_wm(struct drm_device *dev, = struct drm_crtc *crtc) > * row at the given clock rate, multiplied by 8. > * */ > temp |=3D PIPE_WM_LINETIME_TIME( > - ((mode->crtc_hdisplay * 1000) / mode->clock) * 8); > + ((mode->htotal * 1000) / mode->clock) * 8); > = > /* IPS watermarks are only used by pipe A, and are ignored by > * pipes B and C. They are calculated similarly to the common > -- = > 1.7.10.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC