From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960Ab3EUGbn (ORCPT ); Tue, 21 May 2013 02:31:43 -0400 Received: from mail-da0-f41.google.com ([209.85.210.41]:64331 "EHLO mail-da0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753979Ab3EUGbm (ORCPT ); Tue, 21 May 2013 02:31:42 -0400 Date: Mon, 20 May 2013 23:31:39 -0700 From: Olof Johansson To: Tony Prisk Cc: Srinivas KANDAGATLA , Russell King , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , "Bergmann, Arnd" Subject: Re: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat Message-ID: <20130521063139.GA20453@quad.lixom.net> References: <1368776657-23035-1-git-send-email-srinivas.kandagatla@st.com> <5195EA34.7000409@prisktech.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5195EA34.7000409@prisktech.co.nz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2013 at 08:28:36PM +1200, Tony Prisk wrote: > On 17/05/13 19:44, Srinivas KANDAGATLA wrote: > >From: Srinivas Kandagatla > > > >When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it > >failed to boot. The issues seems to be changing by enabling or disabling > >VT8550 platform. Having a quick look at dt_compat list, it seems to miss > >a NULL terminator, which means of_flat_dt_match will compat check will > >cross the boundary of dt_compat and fault at some point , which is what > >was happening in my case. > > > >Without this patch if we try to boot multi_v7_defconfig you might notice > >that some of the platforms might fault if they fall after vt8500 in > >machine-desc list. Other platforms which fall before vt8500 in mdesc list > >will not fault. > > > >Signed-off-by: Srinivas Kandagatla > >--- > > arch/arm/mach-vt8500/vt8500.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > >diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c > >index 1dd281e..f5c33df 100644 > >--- a/arch/arm/mach-vt8500/vt8500.c > >+++ b/arch/arm/mach-vt8500/vt8500.c > >@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = { > > "wm,wm8505", > > "wm,wm8750", > > "wm,wm8850", > >+ NULL > > }; > > DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)") > My bad. Thanks for the fix. > > Acked-by: Tony Prisk > > Arnd, Olof: Can you apply this directly please. Done. Thanks, -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Mon, 20 May 2013 23:31:39 -0700 Subject: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat In-Reply-To: <5195EA34.7000409@prisktech.co.nz> References: <1368776657-23035-1-git-send-email-srinivas.kandagatla@st.com> <5195EA34.7000409@prisktech.co.nz> Message-ID: <20130521063139.GA20453@quad.lixom.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 17, 2013 at 08:28:36PM +1200, Tony Prisk wrote: > On 17/05/13 19:44, Srinivas KANDAGATLA wrote: > >From: Srinivas Kandagatla > > > >When I tried booting a stih415 Dual core A9 with multi_v7_defconfig, it > >failed to boot. The issues seems to be changing by enabling or disabling > >VT8550 platform. Having a quick look at dt_compat list, it seems to miss > >a NULL terminator, which means of_flat_dt_match will compat check will > >cross the boundary of dt_compat and fault at some point , which is what > >was happening in my case. > > > >Without this patch if we try to boot multi_v7_defconfig you might notice > >that some of the platforms might fault if they fall after vt8500 in > >machine-desc list. Other platforms which fall before vt8500 in mdesc list > >will not fault. > > > >Signed-off-by: Srinivas Kandagatla > >--- > > arch/arm/mach-vt8500/vt8500.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > >diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c > >index 1dd281e..f5c33df 100644 > >--- a/arch/arm/mach-vt8500/vt8500.c > >+++ b/arch/arm/mach-vt8500/vt8500.c > >@@ -173,6 +173,7 @@ static const char * const vt8500_dt_compat[] = { > > "wm,wm8505", > > "wm,wm8750", > > "wm,wm8850", > >+ NULL > > }; > > DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)") > My bad. Thanks for the fix. > > Acked-by: Tony Prisk > > Arnd, Olof: Can you apply this directly please. Done. Thanks, -Olof