From: Arnaldo Carvalho de Melo <acme@infradead.org> To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Irina Tirdea <irina.tirdea@intel.com>, Frederic Weisbecker <fweisbec@gmail.com>, yrl.pp-manager.tt@hitachi.com, Oleg Nesterov <oleg@redhat.com>, Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>, Tom Zanussi <tom.zanussi@intel.com>, Namhyung Kim <namhyung@kernel.org>, Borislav Petkov <bp@suse.de>, Jiri Olsa <jolsa@redhat.com>, Peter Zijlstra <a.p.zijlstra@chello.nl> Subject: Re: [PATCH 2/5] perf: Reorder parameters of strglobmatch Date: Tue, 21 May 2013 11:19:47 +0200 [thread overview] Message-ID: <20130521091947.GD10541@ghostprotocols.net> (raw) In-Reply-To: <51959417.7070403@hitachi.com> Em Fri, May 17, 2013 at 11:21:11AM +0900, Masami Hiramatsu escreveu: > (2013/05/16 23:55), Steven Rostedt wrote: > > I'm a bit confused to the rational here. Can you explain in more detail > > to why this patch is actually needed? > Yes, actually, this patch is not needed from the viewpoint of execution, > but less misuse for future use of the strglobmatch, I think. > For example, glob(3) has the pattern parameter as the first one, > > int glob(const char *pattern, int flags, > int (*errfunc) (const char *epath, int eerrno), > glob_t *pglob); > regexec(3) also has the compiled regexp at the first parameter, > int regexec(const regex_t *preg, const char *string, size_t nmatch, > regmatch_t pmatch[], int eflags); > Thus, I think a new user of strglobmatch() may guess that the first > parameter should be the glob pattern. > So, this patch is not technically needed, but from the viewpoint of coding > naturally, it should be changed, IMHO. So I suggest you state this in the changeset comment :-) - Arnaldo
next prev parent reply other threads:[~2013-05-21 9:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-16 11:48 [PATCH 0/5] Add glob pattern matching support on trigger and kprobe-event Masami Hiramatsu 2013-05-16 11:48 ` [PATCH 1/5] [BUGFIX] tracing: Returns -EBUSY when event_enable_func fails to get module Masami Hiramatsu 2013-05-16 14:58 ` Steven Rostedt 2013-05-16 11:48 ` [PATCH 2/5] perf: Reorder parameters of strglobmatch Masami Hiramatsu 2013-05-16 14:55 ` Steven Rostedt 2013-05-17 2:21 ` Masami Hiramatsu 2013-05-21 9:19 ` Arnaldo Carvalho de Melo [this message] 2013-05-21 9:49 ` Masami Hiramatsu 2013-05-16 11:48 ` [PATCH 3/5] lib/string: Add a generic wildcard string matching function Masami Hiramatsu 2013-05-16 11:48 ` [PATCH 4/5] tracing/kprobes: Allow user to delete kprobe events by wild cards Masami Hiramatsu 2013-05-16 11:49 ` [PATCH 5/5] tracing: Support enable/disable multiple events trigger " Masami Hiramatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130521091947.GD10541@ghostprotocols.net \ --to=acme@infradead.org \ --cc=a.p.zijlstra@chello.nl \ --cc=bp@suse.de \ --cc=dsahern@gmail.com \ --cc=fweisbec@gmail.com \ --cc=irina.tirdea@intel.com \ --cc=jolsa@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=masami.hiramatsu.pt@hitachi.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=oleg@redhat.com \ --cc=paulus@samba.org \ --cc=penberg@kernel.org \ --cc=rostedt@goodmis.org \ --cc=srikar@linux.vnet.ibm.com \ --cc=tom.zanussi@intel.com \ --cc=yrl.pp-manager.tt@hitachi.com \ --subject='Re: [PATCH 2/5] perf: Reorder parameters of strglobmatch' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.