Re: [LTP] [PATCH v2 2/2] waitid02: split code into separate testcases

[chrubis@suse.cz]

Hi!
> -int TST_TOTAL = 4;
> +static int TST_TOTAL = sizeof(tdat) / sizeof(tdat[0]);

You can use ARRAY_SIZE() macro we have. ;)

> -		}
> +		/* setup alarm for unlikely event that test blocks */
> +		alarm(5);

I'm slightly against adding timeouts to tests in this fashion.

The correct solution for this would be making the test driver to kill
the test after some timeout. Which is what I want to solve with new test
execution framework (that unfortunately does not exist at the moment).

I guess that we can hack around some default timeout (30 mins or
something equally big) into ltp-pan.c for the time being. Which would at
least assure that the testsuite will not hang forever. We can't do
anything smarter without anotating long lived testcases (more than five
minutes or so) with proper timeouts in the runtest files though :(.

>  	cleanup();
>  	tst_exit();

The rest is fine.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list