From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755755Ab3EVS7K (ORCPT ); Wed, 22 May 2013 14:59:10 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:19461 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259Ab3EVS7I (ORCPT ); Wed, 22 May 2013 14:59:08 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19wUV88IqY/4IMaAyznRSeLGHAn8RheJGQ= Date: Wed, 22 May 2013 14:58:35 -0400 From: Jason Cooper To: Sebastian Hesselbarth Cc: Jason Gunthorpe , "tiejun.chen" , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, David Miller , Lennert Buytenhek Subject: Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes Message-ID: <20130522185834.GL31290@titan.lakedaemon.net> References: <519C9A66.3050807@gmail.com> <20130522131010.GB31290@titan.lakedaemon.net> <20130522165908.GB12320@obsidianresearch.com> <519D0143.1000203@gmail.com> <20130522173505.GH31290@titan.lakedaemon.net> <519D038C.9000605@gmail.com> <20130522174815.GI31290@titan.lakedaemon.net> <519D1204.4090701@gmail.com> <20130522184936.GK31290@titan.lakedaemon.net> <519D1485.50801@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519D1485.50801@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>>>Hmm, maybe a little bit too early. While restoring the MAC address now > >>>>works, another bug arises which I guess is related with phy setup > >>>>and aneg. > >>>> > >>>>Will investigate and update patch set accordingly. > >>> > >>>Cool, chances are, we should be able to take that patch in by itself for > >>>this merge window... > >> > >>Which patch do you mean? The local-mac-address workaround will only be > >>available for DT mv643xx_eth because it uses the DT node to store the > >>MAC. > > > >I thought you were replacing the unconditional ethernet clock grabbing > >with reading the mac from the registers and updating the dtb? In > >mach-kirkwood/board-dt.c? > > True. But there is no node for ethernet controllers in kirkwood.dtsi > yet. It will be there with mv643xx_eth DT patches applied and that is > when the corresponding replacement patch should also be taken in. > > I was just confused about your referral to the merge window, because I > guess it is up to David Miller to decide when/whether to take > mv643xx_eth patches in. Ahh, no, that was me. I was contemplating adding the dt entries in this merge window at one point and must've got my wires crossed. Sorry for the confusion. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes Date: Wed, 22 May 2013 14:58:35 -0400 Message-ID: <20130522185834.GL31290@titan.lakedaemon.net> References: <519C9A66.3050807@gmail.com> <20130522131010.GB31290@titan.lakedaemon.net> <20130522165908.GB12320@obsidianresearch.com> <519D0143.1000203@gmail.com> <20130522173505.GH31290@titan.lakedaemon.net> <519D038C.9000605@gmail.com> <20130522174815.GI31290@titan.lakedaemon.net> <519D1204.4090701@gmail.com> <20130522184936.GK31290@titan.lakedaemon.net> <519D1485.50801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , "tiejun.chen" , Lennert Buytenhek , linuxppc-dev@lists.ozlabs.org, David Miller , linux-arm-kernel@lists.infradead.org To: Sebastian Hesselbarth Return-path: Content-Disposition: inline In-Reply-To: <519D1485.50801@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: netdev.vger.kernel.org On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>>>Hmm, maybe a little bit too early. While restoring the MAC address now > >>>>works, another bug arises which I guess is related with phy setup > >>>>and aneg. > >>>> > >>>>Will investigate and update patch set accordingly. > >>> > >>>Cool, chances are, we should be able to take that patch in by itself for > >>>this merge window... > >> > >>Which patch do you mean? The local-mac-address workaround will only be > >>available for DT mv643xx_eth because it uses the DT node to store the > >>MAC. > > > >I thought you were replacing the unconditional ethernet clock grabbing > >with reading the mac from the registers and updating the dtb? In > >mach-kirkwood/board-dt.c? > > True. But there is no node for ethernet controllers in kirkwood.dtsi > yet. It will be there with mv643xx_eth DT patches applied and that is > when the corresponding replacement patch should also be taken in. > > I was just confused about your referral to the merge window, because I > guess it is up to David Miller to decide when/whether to take > mv643xx_eth patches in. Ahh, no, that was me. I was contemplating adding the dt entries in this merge window at one point and must've got my wires crossed. Sorry for the confusion. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Wed, 22 May 2013 14:58:35 -0400 Subject: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes In-Reply-To: <519D1485.50801@gmail.com> References: <519C9A66.3050807@gmail.com> <20130522131010.GB31290@titan.lakedaemon.net> <20130522165908.GB12320@obsidianresearch.com> <519D0143.1000203@gmail.com> <20130522173505.GH31290@titan.lakedaemon.net> <519D038C.9000605@gmail.com> <20130522174815.GI31290@titan.lakedaemon.net> <519D1204.4090701@gmail.com> <20130522184936.GK31290@titan.lakedaemon.net> <519D1485.50801@gmail.com> Message-ID: <20130522185834.GL31290@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>>>Hmm, maybe a little bit too early. While restoring the MAC address now > >>>>works, another bug arises which I guess is related with phy setup > >>>>and aneg. > >>>> > >>>>Will investigate and update patch set accordingly. > >>> > >>>Cool, chances are, we should be able to take that patch in by itself for > >>>this merge window... > >> > >>Which patch do you mean? The local-mac-address workaround will only be > >>available for DT mv643xx_eth because it uses the DT node to store the > >>MAC. > > > >I thought you were replacing the unconditional ethernet clock grabbing > >with reading the mac from the registers and updating the dtb? In > >mach-kirkwood/board-dt.c? > > True. But there is no node for ethernet controllers in kirkwood.dtsi > yet. It will be there with mv643xx_eth DT patches applied and that is > when the corresponding replacement patch should also be taken in. > > I was just confused about your referral to the merge window, because I > guess it is up to David Miller to decide when/whether to take > mv643xx_eth patches in. Ahh, no, that was me. I was contemplating adding the dt entries in this merge window at one point and must've got my wires crossed. Sorry for the confusion. thx, Jason.