From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW
Date: Fri, 24 May 2013 19:20:54 +0300 [thread overview]
Message-ID: <20130524162054.GJ5004@intel.com> (raw)
In-Reply-To: <CAKMK7uGDqmB13pfQFCqVWSjG23COgGww4=7AFoOt9yFJ2_NLFw@mail.gmail.com>
On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > pfit_size stores the request mode, which matches crtc->config.requested
> > mode. Instead of jumping through hoops I think I'd be better to directly
> > use those values ...
>
> Scrap that, I can't read code ;-)
One change I'd like is to store the pfit window w/h as individual values
instead of sticking the raw register value into pipe_config. Nothing else
seems to be stored there in raw form, so it feels inconsistent. And it
would avoid the mask/shift busniness when extracting the values.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-05-24 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 20:38 [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW Paulo Zanoni
2013-05-09 20:13 ` Paulo Zanoni
2013-05-20 15:56 ` Ville Syrjälä
2013-05-21 21:24 ` Paulo Zanoni
2013-05-22 7:25 ` Ville Syrjälä
2013-05-24 15:05 ` Paulo Zanoni
2013-05-24 16:07 ` Daniel Vetter
2013-05-24 16:13 ` Daniel Vetter
2013-05-24 16:20 ` Ville Syrjälä [this message]
2013-05-25 16:01 ` Daniel Vetter
2013-05-21 13:08 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524162054.GJ5004@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.