From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Sat, 25 May 2013 01:24:34 +0000 Subject: Re: [RFC/PATCH v2 0/2] R-Car GPIO DT bindings Message-Id: <20130525012434.GA24005@verge.net.au> List-Id: References: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tue, May 21, 2013 at 01:40:04PM +0200, Laurent Pinchart wrote: > Hello, > > Here's the second version of the gpio-rcar driver DT bindings. I've tested the > patches on the Marzen board (r8a7779). > > Once again I'd appreciate feedback on the DT bindings. I'm particularly > wondering whether getting the number of lines through the gpio-ranges property > instead of using a dedicated #gpio-lines property as in v1 is a good idea. > > Changes since v1: > > - Initialize the gpiochip dev field at probe time. > - Add the gpio-ranges property. > - Remove the #gpio-lines property. The number of lines is now passed through > the gpio-ranges property. > > Laurent Pinchart (2): > gpio-rcar: Make the platform data gpio_base field signed > gpio-rcar: Add DT support > > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 52 +++++++++++++++++ > drivers/gpio/gpio-rcar.c | 66 ++++++++++++++++++---- > include/linux/platform_data/gpio-rcar.h | 2 +- > 3 files changed, 109 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt Hi Magnus, could you please review these changes? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [RFC/PATCH v2 0/2] R-Car GPIO DT bindings Date: Sat, 25 May 2013 10:24:34 +0900 Message-ID: <20130525012434.GA24005@verge.net.au> References: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Magnus Damm , Guennadi Liakhovetski List-Id: devicetree@vger.kernel.org On Tue, May 21, 2013 at 01:40:04PM +0200, Laurent Pinchart wrote: > Hello, > > Here's the second version of the gpio-rcar driver DT bindings. I've tested the > patches on the Marzen board (r8a7779). > > Once again I'd appreciate feedback on the DT bindings. I'm particularly > wondering whether getting the number of lines through the gpio-ranges property > instead of using a dedicated #gpio-lines property as in v1 is a good idea. > > Changes since v1: > > - Initialize the gpiochip dev field at probe time. > - Add the gpio-ranges property. > - Remove the #gpio-lines property. The number of lines is now passed through > the gpio-ranges property. > > Laurent Pinchart (2): > gpio-rcar: Make the platform data gpio_base field signed > gpio-rcar: Add DT support > > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 52 +++++++++++++++++ > drivers/gpio/gpio-rcar.c | 66 ++++++++++++++++++---- > include/linux/platform_data/gpio-rcar.h | 2 +- > 3 files changed, 109 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt Hi Magnus, could you please review these changes? From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Sat, 25 May 2013 10:24:34 +0900 Subject: [RFC/PATCH v2 0/2] R-Car GPIO DT bindings In-Reply-To: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1369136406-23800-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: <20130525012434.GA24005@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 21, 2013 at 01:40:04PM +0200, Laurent Pinchart wrote: > Hello, > > Here's the second version of the gpio-rcar driver DT bindings. I've tested the > patches on the Marzen board (r8a7779). > > Once again I'd appreciate feedback on the DT bindings. I'm particularly > wondering whether getting the number of lines through the gpio-ranges property > instead of using a dedicated #gpio-lines property as in v1 is a good idea. > > Changes since v1: > > - Initialize the gpiochip dev field at probe time. > - Add the gpio-ranges property. > - Remove the #gpio-lines property. The number of lines is now passed through > the gpio-ranges property. > > Laurent Pinchart (2): > gpio-rcar: Make the platform data gpio_base field signed > gpio-rcar: Add DT support > > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 52 +++++++++++++++++ > drivers/gpio/gpio-rcar.c | 66 ++++++++++++++++++---- > include/linux/platform_data/gpio-rcar.h | 2 +- > 3 files changed, 109 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt Hi Magnus, could you please review these changes?