From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 16/18] drm/i915: add VEBOX into debugfs Date: Tue, 28 May 2013 16:06:07 +0100 Message-ID: <20130528150607.GI10995@strange.amr.corp.intel.com> References: <1367110769-1306-1-git-send-email-ben@bwidawsk.net> <1367110769-1306-17-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id B45BAE5C8F for ; Tue, 28 May 2013 08:06:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367110769-1306-17-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel-GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 27, 2013 at 05:59:27PM -0700, Ben Widawsky wrote: > From: "Xiang, Haihao" > > v2 (Ben): s/hsw/hws > > Signed-off-by: Xiang, Haihao > [Order changed, and modified by] > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index a55630a..71fb7aa 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -379,6 +379,17 @@ static int i915_gem_request_info(struct seq_file *m, void *data) > } > count++; > } > + if (!list_empty(&dev_priv->ring[VECS].request_list)) { > + seq_printf(m, "VEBOX requests:\n"); > + list_for_each_entry(gem_request, > + &dev_priv->ring[VECS].request_list, > + list) { > + seq_printf(m, " %d @ %d\n", > + gem_request->seqno, > + (int) (jiffies - gem_request->emitted_jiffies)); > + } > + count++; > + } > mutex_unlock(&dev->struct_mutex); That block doesn't seem necessary as the code above this chuck cycles over all the rings? > > if (count == 0) > @@ -570,6 +581,7 @@ static const char *ring_str(int ring) > case RCS: return "render"; > case VCS: return "bsd"; > case BCS: return "blt"; > + case VECS: return "vebox"; > default: return ""; > } > } > @@ -2099,6 +2111,7 @@ static struct drm_info_list i915_debugfs_list[] = { > {"i915_gem_hws", i915_hws_info, 0, (void *)RCS}, > {"i915_gem_hws_blt", i915_hws_info, 0, (void *)BCS}, > {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS}, > + {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS}, > {"i915_rstdby_delays", i915_rstdby_delays, 0}, > {"i915_cur_delayinfo", i915_cur_delayinfo, 0}, > {"i915_delayfreq_table", i915_delayfreq_table, 0}, > -- > 1.8.2.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx