From: Fam Zheng <famz@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read
Date: Wed, 29 May 2013 09:07:25 +0800 [thread overview]
Message-ID: <20130529010725.GA3181@localhost.nay.redhat.com> (raw)
In-Reply-To: <20130528113215.GD5105@redhat.com>
On Tue, 05/28 12:32, Richard W.M. Jones wrote:
>
> This fixes the obvious bug.
Thanks for figuring out this. Mainline had this 5s timeout so I kept it,
but you don't experience this bug, right? Since master doesn't setup a
timer to get curl notified about the timing, the option is just not
effective.
> I wonder if it should be even larger? One use for curl is to install
> guests using ISOs from websites without having to download the ISO,
> and I imagine that even a 30 second timeout could be conservative for
> that task.
>
Long latency network is common in practice, as well as low bandwidth,
the meaning of the timeout is to complete the request, in extreme cases
if it is a 1Kbps link, downloading 256k takes minutes. Anyway, I think
making it larger won't hurt.
--
Fam
next prev parent reply other threads:[~2013-05-29 1:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 5:36 [Qemu-devel] [PATCH v6 00/12] curl: fix curl read Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 01/12] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 02/12] curl: change magic number to sizeof Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 03/12] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 04/12] curl: fix curl_open Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 05/12] curl: add timer to BDRVCURLState Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 06/12] curl: introduce CURLDataCache Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 07/12] curl: make use of CURLDataCache Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 08/12] curl: use list to store CURLState Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 09/12] curl: add cache quota Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 10/12] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 11/12] block/curl.c: Refuse to open the handle for writes Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 12/12] curl: set s->url to NULL after free Fam Zheng
2013-05-24 8:07 ` [Qemu-devel] [PATCH v6 00/12] curl: fix curl read Richard W.M. Jones
2013-05-27 2:25 ` Fam Zheng
2013-05-27 11:57 ` Richard W.M. Jones
2013-05-28 7:30 ` Fam Zheng
2013-05-28 7:47 ` Richard W.M. Jones
2013-05-28 8:46 ` Richard W.M. Jones
2013-05-28 8:52 ` Fam Zheng
2013-05-28 8:53 ` Richard W.M. Jones
2013-05-28 10:35 ` Richard W.M. Jones
2013-05-28 11:01 ` Richard W.M. Jones
2013-05-28 11:14 ` Fam Zheng
2013-05-28 11:25 ` Richard W.M. Jones
2013-05-28 11:32 ` Richard W.M. Jones
2013-05-29 1:07 ` Fam Zheng [this message]
2013-05-29 9:25 ` Richard W.M. Jones
2013-05-28 11:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529010725.GA3181@localhost.nay.redhat.com \
--to=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.