From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhY5P-0000VL-AV for qemu-devel@nongnu.org; Wed, 29 May 2013 00:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhY5L-00015F-6j for qemu-devel@nongnu.org; Wed, 29 May 2013 00:34:07 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:37534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhY5K-00014e-RR for qemu-devel@nongnu.org; Wed, 29 May 2013 00:34:03 -0400 Date: Wed, 29 May 2013 14:08:01 +1000 From: David Gibson Message-ID: <20130529040801.GA5489@boomeroo.fritz.box> References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-22-git-send-email-pbonzini@redhat.com> <519E6CEE.1080201@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <519E6CEE.1080201@redhat.com> Subject: Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , qemu-devel@nongnu.org, jan.kiszka@gmail.com --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2013 at 09:24:30PM +0200, Paolo Bonzini wrote: > Il 23/05/2013 20:27, Peter Maydell ha scritto: > > On 21 May 2013 11:57, Paolo Bonzini wrote: > >> From: David Gibson > >> > >> This patch adds a NotifierList to MemoryRegions which represent IOMMUs > >> allowing other parts of the code to register interest in mappings or > >> unmappings from the IOMMU. All IOMMU implementations will need to call > >> memory_region_notify_iommu() to inform those waiting on the notifier l= ist, > >> whenever an IOMMU mapping is made or removed. > >> > >> Signed-off-by: David Gibson > >> @@ -423,6 +425,11 @@ static inline bool memory_region_is_romd(MemoryRe= gion *mr) > >> */ > >> bool memory_region_is_iommu(MemoryRegion *mr); > >> > >> +void memory_region_notify_iommu(MemoryRegion *mr, > >> + IOMMUTLBEntry entry); > >> +void memory_region_register_iommu_notifier(MemoryRegion *mr, Notifier= *n); > >> +void memory_region_unregister_iommu_notifier(Notifier *n); > >=20 > > These all need doc comments. >=20 > David, can you provide them? (If not as a patch, just an inline reply > to this email will do). I'll see what I can do. Working on this is no longer my day job, so it may be a little while... --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGlfyEACgkQaILKxv3ab8bJegCcCF4ZII+RbjSE2qRY5Ngwp6d/ /K0AoI/4uAtnsoG5RCzgoTJOQctTJ3n3 =tFOJ -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--