From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965017Ab3E2HxA (ORCPT ); Wed, 29 May 2013 03:53:00 -0400 Received: from merlin.infradead.org ([205.233.59.134]:47748 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964806Ab3E2Hw7 (ORCPT ); Wed, 29 May 2013 03:52:59 -0400 Date: Wed, 29 May 2013 09:52:49 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: "Paul E. McKenney" , LKML , Tejun Heo , Ingo Molnar , Frederic Weisbecker , Jiri Olsa Subject: Re: [RFC][PATCH] ftrace: Use schedule_on_each_cpu() as a heavy synchronize_sched() Message-ID: <20130529075249.GC12193@twins.programming.kicks-ass.net> References: <1369785676.15552.55.camel@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369785676.15552.55.camel@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2013 at 08:01:16PM -0400, Steven Rostedt wrote: > The function tracer uses preempt_disable/enable_notrace() for > synchronization between reading registered ftrace_ops and unregistering > them. > > Most of the ftrace_ops are global permanent structures that do not > require this synchronization. That is, ops may be added and removed from > the hlist but are never freed, and wont hurt if a synchronization is > missed. > > But this is not true for dynamically created ftrace_ops or control_ops, > which are used by the perf function tracing. > > The problem here is that the function tracer can be used to trace > kernel/user context switches as well as going to and from idle. > Basically, it can be used to trace blind spots of the RCU subsystem. > This means that even though preempt_disable() is done, a > synchronize_sched() will ignore CPUs that haven't made it out of user > space or idle. These can include functions that are being traced just > before entering or exiting the kernel sections. Just to be clear, its the idle part that's a problem, right? Being stuck in userspace isn't a problem since if that CPU is in userspace its certainly not got a reference to whatever list entry we're removing. Now when the CPU really is idle, its obviously not using tracing either; so only the gray area where RCU thinks we're idle but we're not actually idle is a problem? Is there something a little smarter we can do? Could we use on_each_cpu_cond() with a function that checks if the CPU really is fully idle? > To implement the RCU synchronization, instead of using > synchronize_sched() the use of schedule_on_each_cpu() is performed. This > means that when a dynamically allocated ftrace_ops, or a control ops is > being unregistered, all CPUs must be touched and execute a ftrace_sync() > stub function via the work queues. This will rip CPUs out from idle or > in dynamic tick mode. This only happens when a user disables perf > function tracing or other dynamically allocated function tracers, but it > allows us to continue to debug RCU and context tracking with function > tracing. I don't suppose there's anything perf can do to about this right? Since its all on user demand we're kinda stuck with dynamic memory.