From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhfm9-0008B3-1y for qemu-devel@nongnu.org; Wed, 29 May 2013 08:46:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhfm3-0000fJ-W5 for qemu-devel@nongnu.org; Wed, 29 May 2013 08:46:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhfm3-0000f6-Oj for qemu-devel@nongnu.org; Wed, 29 May 2013 08:46:39 -0400 Date: Wed, 29 May 2013 14:46:37 +0200 From: Kevin Wolf Message-ID: <20130529124637.GI3521@dhcp-200-207.str.redhat.com> References: <1369827246-2802-1-git-send-email-kwolf@redhat.com> <1369827246-2802-3-git-send-email-kwolf@redhat.com> <51A5EB9E.7000607@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51A5EB9E.7000607@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 29.05.2013 um 13:50 hat Andreas F=E4rber geschrieben: > Am 29.05.2013 13:34, schrieb Kevin Wolf: > > From: Andreas F=E4rber > >=20 > > The implementation of the ATA FLUSH command invokes a flush at the bl= ock > > layer, which may on raw files on POSIX entail a synchronous fdatasync= (). > > This may in some cases take so long that the SLES 11 SP1 guest driver > > reports I/O errors and filesystems get corrupted or remounted read-on= ly. > >=20 > > Avoid this by setting BUSY_STAT, so that the guest is made aware we a= re > > in the middle of an operation and no ATA commands are attempted to be > > processed concurrently. > >=20 > > Addresses BNC#637297. > >=20 > > Suggested-by: Gonglei (Arei) > > Signed-off-by: Andreas F=E4rber > > Signed-off-by: Kevin Wolf > > --- > > hw/ide/core.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/hw/ide/core.c b/hw/ide/core.c > > index c7a8041..bf1ff18 100644 > > --- a/hw/ide/core.c > > +++ b/hw/ide/core.c > > @@ -795,6 +795,8 @@ static void ide_flush_cb(void *opaque, int ret) > > { > > IDEState *s =3D opaque; > > =20 > > + s->status &=3D ~BUSY_STAT; > > + > > if (ret < 0) { > > /* XXX: What sector number to set here? */ > > if (ide_handle_rw_error(s, -ret, BM_STATUS_RETRY_FLUSH)) { >=20 > Didn't you want this hunk to be dropped? >=20 > But thanks for picking the patch up already. Ah, right, dropped it now. Thanks. Kevin