From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 13/18] drm/i915: consolidate interrupt
 naming scheme
Date: Wed, 29 May 2013 16:51:19 +0100
Message-ID: <20130529155119.GC17389@strange.amr.corp.intel.com>
References: <1367110769-1306-1-git-send-email-ben@bwidawsk.net>
	<1367110769-1306-14-git-send-email-ben@bwidawsk.net>
	<20130528140154.GF10995@strange.amr.corp.intel.com>
	<20130528185046.GC1464@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id D620CE5CB1
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 29 May 2013 08:51:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130528185046.GC1464@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel-GFX <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 28, 2013 at 11:50:46AM -0700, Ben Widawsky wrote:
> > > -	if (gt_iir & (GT_GEN6_BLT_CS_ERROR_INTERRUPT |
> > > -		      GT_GEN6_BSD_CS_ERROR_INTERRUPT |
> > > -		      GT_RENDER_CS_ERROR_INTERRUPT)) {
> > > +	if (gt_iir & (GT_BLT_CS_ERROR_INTERRUPT |
> > > +		      GT_BSD_CS_ERROR_INTERRUPT |
> > > +		      GT_RENDER_MASTER_ERROR_INTERRUPT)) {
> > 
> > If we ware in the naming domain here, not sure why the CS master error
> > for render would have a different name than the others,
> > GT_RENDER_CS_ERROR_INTERRUPT looked good to me.
> 
> I was just copying the docs. I presume on earlier gens, maybe it meant
> something else? It seems I accidently dropped the "CS" part though. I've
> added that back, and left the MASTER.
> 
> "Render Command Parser Master Error"

They are all called $engine Command Parser Master Error, my point was
they should look alike (and I'd just drop the master, I think it's just
because it means an aggregate of the possible CS errors (2 at most as
far as I can see, privilege error and  bad command).

-- 
Damien