From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966623Ab3E2UCE (ORCPT ); Wed, 29 May 2013 16:02:04 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:14704 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934987Ab3E2UBy (ORCPT ); Wed, 29 May 2013 16:01:54 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18SPqytOZE5xmxApSbJpgIKLHrmm4mkskU= Date: Wed, 29 May 2013 16:00:53 -0400 From: Jason Cooper To: Sebastian Hesselbarth Cc: David Miller , Lennert Buytenhek , Andrew Lunn , Benjamin Herrenschmidt , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/13] net: mv643xx_eth: use phy_disconnect instead of phy_detach Message-ID: <20130529200053.GA31290@titan.lakedaemon.net> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian, On Wed, May 29, 2013 at 09:32:43PM +0200, Sebastian Hesselbarth wrote: > Using a separated mdio bus driver with mvmdio, phy_detach on network device > removal will not stop the phy and finally lead to NULL pointer dereference > in mvmdio due to non-existent network device. Use phy_disconnect instead > to properly stop phy device from accessing network device prior removal of > the network device. > > Signed-off-by: Sebastian Hesselbarth > --- > Note: I observed this behavior when removing a modular mv643xx_eth driver > after attaching it to a phy handled by (also modular) mvmdio. The mvmdio > conversion has been done in > > commit c3a07134e6aa5b93a37f72ffa3d11fadf72bf757 > ("mv643xx_eth: convert to use the Marvell Orion MDIO driver") > > and should go back any -stable version with that commit (propably only 3.9) It looks like just v3.10-rcX, here. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v5 01/13] net: mv643xx_eth: use phy_disconnect instead of phy_detach Date: Wed, 29 May 2013 16:00:53 -0400 Message-ID: <20130529200053.GA31290@titan.lakedaemon.net> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lennert Buytenhek , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, David Miller , linux-arm-kernel@lists.infradead.org To: Sebastian Hesselbarth Return-path: Content-Disposition: inline In-Reply-To: <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org Sebastian, On Wed, May 29, 2013 at 09:32:43PM +0200, Sebastian Hesselbarth wrote: > Using a separated mdio bus driver with mvmdio, phy_detach on network device > removal will not stop the phy and finally lead to NULL pointer dereference > in mvmdio due to non-existent network device. Use phy_disconnect instead > to properly stop phy device from accessing network device prior removal of > the network device. > > Signed-off-by: Sebastian Hesselbarth > --- > Note: I observed this behavior when removing a modular mv643xx_eth driver > after attaching it to a phy handled by (also modular) mvmdio. The mvmdio > conversion has been done in > > commit c3a07134e6aa5b93a37f72ffa3d11fadf72bf757 > ("mv643xx_eth: convert to use the Marvell Orion MDIO driver") > > and should go back any -stable version with that commit (propably only 3.9) It looks like just v3.10-rcX, here. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2E9B92C0350 for ; Thu, 30 May 2013 06:01:23 +1000 (EST) Date: Wed, 29 May 2013 16:00:53 -0400 From: Jason Cooper To: Sebastian Hesselbarth Subject: Re: [PATCH v5 01/13] net: mv643xx_eth: use phy_disconnect instead of phy_detach Message-ID: <20130529200053.GA31290@titan.lakedaemon.net> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lennert Buytenhek , linuxppc-dev@lists.ozlabs.org, David Miller , linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sebastian, On Wed, May 29, 2013 at 09:32:43PM +0200, Sebastian Hesselbarth wrote: > Using a separated mdio bus driver with mvmdio, phy_detach on network device > removal will not stop the phy and finally lead to NULL pointer dereference > in mvmdio due to non-existent network device. Use phy_disconnect instead > to properly stop phy device from accessing network device prior removal of > the network device. > > Signed-off-by: Sebastian Hesselbarth > --- > Note: I observed this behavior when removing a modular mv643xx_eth driver > after attaching it to a phy handled by (also modular) mvmdio. The mvmdio > conversion has been done in > > commit c3a07134e6aa5b93a37f72ffa3d11fadf72bf757 > ("mv643xx_eth: convert to use the Marvell Orion MDIO driver") > > and should go back any -stable version with that commit (propably only 3.9) It looks like just v3.10-rcX, here. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Wed, 29 May 2013 16:00:53 -0400 Subject: [PATCH v5 01/13] net: mv643xx_eth: use phy_disconnect instead of phy_detach In-Reply-To: <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369855975-21489-2-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: <20130529200053.GA31290@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sebastian, On Wed, May 29, 2013 at 09:32:43PM +0200, Sebastian Hesselbarth wrote: > Using a separated mdio bus driver with mvmdio, phy_detach on network device > removal will not stop the phy and finally lead to NULL pointer dereference > in mvmdio due to non-existent network device. Use phy_disconnect instead > to properly stop phy device from accessing network device prior removal of > the network device. > > Signed-off-by: Sebastian Hesselbarth > --- > Note: I observed this behavior when removing a modular mv643xx_eth driver > after attaching it to a phy handled by (also modular) mvmdio. The mvmdio > conversion has been done in > > commit c3a07134e6aa5b93a37f72ffa3d11fadf72bf757 > ("mv643xx_eth: convert to use the Marvell Orion MDIO driver") > > and should go back any -stable version with that commit (propably only 3.9) It looks like just v3.10-rcX, here. thx, Jason.