From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1UhrcM-0001NL-KC
	for qemu-devel@nongnu.org; Wed, 29 May 2013 21:25:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1UhrcH-0003Qv-Vi
	for qemu-devel@nongnu.org; Wed, 29 May 2013 21:25:26 -0400
Received: from mail-qe0-f44.google.com ([209.85.128.44]:49601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1UhrcH-0003Qp-SC
	for qemu-devel@nongnu.org; Wed, 29 May 2013 21:25:21 -0400
Received: by mail-qe0-f44.google.com with SMTP id 6so5618436qeb.31
	for <qemu-devel@nongnu.org>; Wed, 29 May 2013 18:25:21 -0700 (PDT)
Date: Wed, 29 May 2013 21:25:19 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20130530012519.GA28625@morn.localdomain>
References: <1369744094-21727-1-git-send-email-akong@redhat.com>
	<20130528225902.GA27056@morn.localdomain>
	<20130529023354.GA2432@t430s.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130529023354.GA2432@t430s.nay.redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for
	q35-pcihost
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: pbonzini@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Wed, May 29, 2013 at 10:33:54AM +0800, Amos Kong wrote:
> On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote:
> > On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote:
> > > -#define FW_PCI_DOMAIN "/pci@i0cf8"
> > > +#define FW_PCI_DOMAIN "/*pci*@i0cf8"
> > 
> > The seabios pattern matching code isn't that sophisticated - I think
> > this could end up doing something unexpected.  Why does it need to
> > change?
> 
> If we start a guest with default machine type (pc-i440fx), the prefix
> of bootindex string is "/pci@i0cf8", if we start guest with -M q35,
> the prefix will become "/q35-pcihost@i0cf8".
> 
> We only match "/pci@i0cf8" in seabios, it causes boot priority of q35
> devices could not be changed.
> 
> We could not change TYPE_Q35_HOST_DEVICE to 'pci' in qemu to adapt
> seabios, so fix the pattern.

It really can't be changed?

> I see glob_prefix() is not powerful, "/*pci*@i0cf8" & "/*@i0cf8" all
> work.
> 
> Or change TYPE_Q35_HOST_DEVICE to "pci-q35" in qemu, and use
> "/pci*@i0cf8" in seabios ?

That would be preferable.

-Kevin