From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 891247F37 for ; Thu, 30 May 2013 10:52:11 -0500 (CDT) Date: Thu, 30 May 2013 10:52:08 -0500 From: Ben Myers Subject: Re: [PATCH 7/9] xfs: kill suid/sgid through the truncate path. Message-ID: <20130530155208.GD20028@sgi.com> References: <1369636707-15150-1-git-send-email-david@fromorbit.com> <1369636707-15150-8-git-send-email-david@fromorbit.com> <51A75F7A.6040302@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51A75F7A.6040302@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Brian Foster Cc: xfs@oss.sgi.com Hey Brian, On Thu, May 30, 2013 at 10:17:30AM -0400, Brian Foster wrote: > On 05/27/2013 02:38 AM, Dave Chinner wrote: > > From: Dave Chinner > > > > XFS has failed to kill suid/sgid bits correctly when truncating > > files of non-zero size since commit c4ed4243 ("xfs: split > > xfs_setattr") introduced in the 3.1 kernel. Fix it. > > > > The code makes sense and I can easily hit an assert when truncating > (extending) a suid file on a debug kernel without this patch (and I see > the suid dropped with the patch). What commands did you use? It seems like this is dealing with S_ISGID, correct? Thanks, Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs