From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 61492E01466 for ; Fri, 31 May 2013 08:35:32 -0700 (PDT) Received: from e6520eb (pac33-2-82-240-38-71.fbx.proxad.net [82.240.38.71]) (Authenticated sender: eukrea) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 380A24B00FD; Fri, 31 May 2013 17:35:25 +0200 (CEST) Date: Fri, 31 May 2013 17:35:24 +0200 From: Eric =?UTF-8?B?QsOpbmFyZA==?= To: Otavio Salvador Message-ID: <20130531173524.137895c4@e6520eb> In-Reply-To: References: <1369850680-18324-1-git-send-email-eric@eukrea.com> <20130531161556.5c06374b@e6520eb> <20130531170240.3a1c27f5@e6520eb> Organization: =?UTF-8?B?RXVrcsOpYQ==?= Electromatique X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH] qt5: add mx5 and mx6 support X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 May 2013 15:35:34 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Le Fri, 31 May 2013 12:04:11 -0300, Otavio Salvador a =C3=A9crit : > On Fri, May 31, 2013 at 12:02 PM, Eric B=C3=A9nard wrot= e: >=20 > > Le Fri, 31 May 2013 12:00:08 -0300, > > Otavio Salvador a =C3=A9crit : > > > > > On Fri, May 31, 2013 at 11:15 AM, Eric B=C3=A9nard = wrote: > > > > > > > Le Fri, 31 May 2013 10:18:44 -0300, > > > > Otavio Salvador a =C3=A9crit : > > > > > > > > > On Wed, May 29, 2013 at 3:04 PM, Eric B=C3=A9nard > > wrote: > > > > > > > > > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and > > i.MX6 > > > > > > - tested on i.MX51, i.MX53 and i.MX6Q > > > > > > > > > > > > Signed-off-by: Eric B=C3=A9nard > > > > > > > > > > > > > > > > ... > > > > > > > > > > > > > > > > recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp | 105 > > > > > > ++++++++++++++++++++++++ > > > > > > recipes-qt/qt5/qtbase_5.0.2.bbappend | 68 > > +++++++++++++++ > > > > > > > > > > > > > > > > ... > > > > > > > > > > Thinking more about it, I think we should put these inside a meta= -qt5 > > > > > directory so we know what will be 'included'. Otherwse we may nee= d to > > > > pick > > > > > every file depending on each layer and it might be difficult to > > > > understand > > > > > what is in use and what is not. > > > > > > > > > please apply as is and create a patch on top of it to achieve the > > > > organization you prefer. > > > > > > > > > > No reason to apply one patch which we know that needs rework. > > > > > > Do you agree with my argument? > > > > > no ;-) > > >=20 > Well; it would be easier if you could explain why. Do you mind to elabora= te > it a little more? >=20 if the argument is "No reason to apply one patch which we know that needs rework" : Changing the organization of the bbappend is not just a mater of editing the patch in a few minutes, it also means testing with and without meta-qt5 and that's very long (and I already did that for v1 when we discussed that initially). 2 days ago you told me that the RFC was fine, now you tell me that needs rework and as I don't have immediate time to rework it so if you want to change the organization or use Chris' way to add layers (which is very elegant) either create a patch to rework this one or rework the patch before applying or drop it for the moment and I may work again on that later (and in that case, please reply with the organization you want so that the work is done only one time). if the argument is "it might be difficult to understand what is in use and what is not" : as soon as you have automatic addition of sublayers you fall in a case where it's not easy to understand what is in use or not whatever is your directory organization. Eric