From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjoDa-0006kh-V3 for qemu-devel@nongnu.org; Tue, 04 Jun 2013 06:11:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjoDW-0003O5-0q for qemu-devel@nongnu.org; Tue, 04 Jun 2013 06:11:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjoDV-0003Ny-PB for qemu-devel@nongnu.org; Tue, 04 Jun 2013 06:11:49 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r54ABnHA004062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Jun 2013 06:11:49 -0400 Date: Tue, 4 Jun 2013 12:11:47 +0200 From: Kevin Wolf Message-ID: <20130604101147.GF2642@dhcp-200-207.str.redhat.com> References: <1369754856-30036-1-git-send-email-kwolf@redhat.com> <1369754856-30036-7-git-send-email-kwolf@redhat.com> <51A6653E.80803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51A6653E.80803@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com Am 29.05.2013 um 22:29 hat Eric Blake geschrieben: > On 05/28/2013 09:27 AM, Kevin Wolf wrote: > > This is the implementation of all qemu-io commands that make sense to be > > called from the qemu monitor, i.e. everything except open, close and > > quit. > > > > Signed-off-by: Kevin Wolf > > --- > > Makefile | 2 +- > > qemu-io-cmds.c | 1835 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > qemu-io.c | 1817 +------------------------------------------------------ > > 3 files changed, 1838 insertions(+), 1816 deletions(-) > > create mode 100644 qemu-io-cmds.c > > I checked the bulk of this patch via: > > $ diff -u <(sed -n '/^-/ s///p' file) <(sed -n '/^\+/ s///p' file) > > The bulk of the patch is blind code motion plus a bit of touchup; I did > however spot one case where you were too eager in your search-and-replace: > > * Memory allocation helpers. > * > - * Make sure memory is aligned by default, or purposefully misaligned if > + * Make sure memory is aligned by default, or purposefully > qemuio_misaligned if > * that is specified on the command line. Whoops, thanks for spotting this. :-) > > + > > +int qemuio_misalign; > > Should this variable be typed 'bool'? It should, but this is merely code motion, so I won't fix it here. Kevin