All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: "李春奇 <Arthur Chunqi Li>" <yzt356@gmail.com>
Cc: kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] Test case of emulating multibyte NOP
Date: Wed, 5 Jun 2013 16:22:32 +0300	[thread overview]
Message-ID: <20130605132232.GC4725@redhat.com> (raw)
In-Reply-To: <CABpY8MKzZ6WosGDRnujVSQ6SG3L5r60wv37hDq4O2+yR4vzLqQ@mail.gmail.com>

On Wed, Jun 05, 2013 at 05:41:41PM +0800, 李春奇 <Arthur Chunqi Li> wrote:
> Add multibyte NOP test case to kvm-unit-tests. This version adds test
> cases into  x86/realmode.c. This can test one of bugs when booting
> RHEL5.9 64-bit.
> 
The patch is mangled. Lines are wrapped, tabs are replaced with spaces.

> Signed-off-by: Arthur Chunqi Li <yzt356@gmail.com>
> ---
>  x86/realmode.c |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/x86/realmode.c b/x86/realmode.c
> index 981be08..e6e48c9 100644
> --- a/x86/realmode.c
> +++ b/x86/realmode.c
> @@ -1504,6 +1504,29 @@ static void test_fninit(void)
>   report("fninit", 0, fsw == 0 && (fcw & 0x103f) == 0x003f);
>  }
> 
> +static void test_nopl(void)
> +{
> +        MK_INSN(nopl1, ".byte 0x90\n\r"); // 1 byte nop
> +        MK_INSN(nopl2, ".byte 0x66, 0x90\n\r"); // 2 bytes nop
> +        MK_INSN(nopl3, ".byte 0x0f, 0x1f, 0x00\n\r"); // 3 bytes nop
> +        MK_INSN(nopl4, ".byte 0x0f, 0x1f, 0x40, 0x00\n\r"); // 4 bytes nop
> +        MK_INSN(nopl5, ".byte 0x0f, 0x1f, 0x44, 0x00, 0x00\n\r"); //
> 5 bytes nop
> +        MK_INSN(nopl6, ".byte 0x66, 0x0f, 0x1f, 0x44, 0x00,
> 0x00\n\r"); // 6 bytes nop
> +        MK_INSN(nopl7, ".byte 0x0f, 0x1f, 0x80, 0x00, 0x00, 0x00,
> 0x00\n\r"); // 7 bytes nop
> +        MK_INSN(nopl8, ".byte 0x0f, 0x1f, 0x84, 0x00, 0x00, 0x00,
> 0x00, 0x00\n\r"); // 8 bytes nop
> +        MK_INSN(nopl9, ".byte 0x66, 0x0f, 0x1f, 0x84, 0x00, 0x00,
> 0x00, 0x00, 0x00\n\r"); // 9 bytes nop
> +        exec_in_big_real_mode(&insn_nopl1);
> +        exec_in_big_real_mode(&insn_nopl2);
> +        exec_in_big_real_mode(&insn_nopl3);
> +        exec_in_big_real_mode(&insn_nopl4);
> +        exec_in_big_real_mode(&insn_nopl5);
> +        exec_in_big_real_mode(&insn_nopl6);
> +        exec_in_big_real_mode(&insn_nopl7);
> +        exec_in_big_real_mode(&insn_nopl8);
> +        exec_in_big_real_mode(&insn_nopl9);
> +        report("nopl", 0, 1);
> +}
> +
>  void realmode_start(void)
>  {
>   test_null();
> @@ -1548,6 +1571,7 @@ void realmode_start(void)
>   test_xlat();
>   test_salc();
>   test_fninit();
> + test_nopl();
> 
>   exit(0);
>  }
> --
> 1.7.9.5

--
			Gleb.

  reply	other threads:[~2013-06-05 13:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  9:41 [PATCH] Test case of emulating multibyte NOP 李春奇 <Arthur Chunqi Li>
2013-06-05 13:22 ` Gleb Natapov [this message]
     [not found] <1370444091-8814-1-git-send-email-yzt356@gmail.com>
2013-06-05 14:56 ` 李春奇 <Arthur Chunqi Li>
2013-06-05 15:11   ` Gleb Natapov
2013-06-05 15:13     ` 李春奇 <Arthur Chunqi Li>
2013-06-05 15:17       ` Gleb Natapov
2013-06-05 15:22         ` 李春奇 <Arthur Chunqi Li>
2013-06-05 15:29           ` Gleb Natapov
2013-06-05 16:02 Arthur Chunqi Li
2013-06-05 16:13 ` Gleb Natapov
2013-06-05 16:28   ` 李春奇 <Arthur Chunqi Li>
2013-06-06  5:40     ` Gleb Natapov
2013-06-06  6:49       ` 李春奇 <Arthur Chunqi Li>
2013-06-06  7:02         ` Gleb Natapov
2013-06-06  7:17           ` 李春奇 <Arthur Chunqi Li>
2013-06-06  7:22             ` 李春奇 <Arthur Chunqi Li>
2013-06-06  7:28               ` Gleb Natapov
2013-06-05 16:07 yzt356

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130605132232.GC4725@redhat.com \
    --to=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yzt356@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.