From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] Test case of emulating multibyte NOP
Date: Wed, 5 Jun 2013 18:11:57 +0300
Message-ID: <20130605151157.GF4725@redhat.com>
References: <1370444091-8814-1-git-send-email-yzt356@gmail.com>
 <CABpY8MLOe9ZEKtxiF_dvcMv8LFujQWMz+EH8uv_6TUHEzS=RTg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>
To: =?utf-8?B?5p2O5pil5aWHIDxBcnRodXIgQ2h1bnFpIExpPg==?=
	<yzt356@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:52013 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755720Ab3FEPMB convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 5 Jun 2013 11:12:01 -0400
Content-Disposition: inline
In-Reply-To: <CABpY8MLOe9ZEKtxiF_dvcMv8LFujQWMz+EH8uv_6TUHEzS=RTg@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jun 05, 2013 at 10:56:54PM +0800, =E6=9D=8E=E6=98=A5=E5=A5=87 <=
Arthur Chunqi Li> wrote:
> Hi Gleb,
> I generate this mail by git send-email and I think the format is OK.
>=20
But I have not received the email, only this your reply to it.

> This is my first try to commit a patch in open source community. Sorr=
y
> for annoying you guys so much.
>=20
> Thanks,
No problem.

> Arthur
>=20
> On Wed, Jun 5, 2013 at 10:54 PM, Arthur Chunqi Li <yzt356@gmail.com> =
wrote:
> > Add multibyte NOP test case to kvm-unit-tests. This version adds te=
st cases into x86/realmode.c. This can test one of bugs when booting RH=
EL5.9 64-bit.
> >
> > Signed-off-by: Arthur Chunqi Li <yzt356@gmail.com>
> > ---
> >  x86/realmode.c |   24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/x86/realmode.c b/x86/realmode.c
> > index 981be08..e103ca6 100644
> > --- a/x86/realmode.c
> > +++ b/x86/realmode.c
> > @@ -1504,6 +1504,29 @@ static void test_fninit(void)
> >         report("fninit", 0, fsw =3D=3D 0 && (fcw & 0x103f) =3D=3D 0=
x003f);
> >  }
> >
> > +static void test_nopl(void)
> > +{
> > +       MK_INSN(nopl1, ".byte 0x90\n\r"); // 1 byte nop
> > +       MK_INSN(nopl2, ".byte 0x66, 0x90\n\r"); // 2 bytes nop
> > +       MK_INSN(nopl3, ".byte 0x0f, 0x1f, 0x00\n\r"); // 3 bytes no=
p
> > +       MK_INSN(nopl4, ".byte 0x0f, 0x1f, 0x40, 0x00\n\r"); // 4 by=
tes nop
> > +       MK_INSN(nopl5, ".byte 0x0f, 0x1f, 0x44, 0x00, 0x00\n\r"); /=
/ 5 bytes nop
> > +       MK_INSN(nopl6, ".byte 0x66, 0x0f, 0x1f, 0x44, 0x00, 0x00\n\=
r"); // 6 bytes nop
> > +       MK_INSN(nopl7, ".byte 0x0f, 0x1f, 0x80, 0x00, 0x00, 0x00, 0=
x00\n\r"); // 7 bytes nop
> > +       MK_INSN(nopl8, ".byte 0x0f, 0x1f, 0x84, 0x00, 0x00, 0x00, 0=
x00, 0x00\n\r"); // 8 bytes nop
> > +       MK_INSN(nopl9, ".byte 0x66, 0x0f, 0x1f, 0x84, 0x00, 0x00, 0=
x00, 0x00, 0x00\n\r"); // 9 bytes nop
> > +       exec_in_big_real_mode(&insn_nopl1);
> > +       exec_in_big_real_mode(&insn_nopl2);
> > +       exec_in_big_real_mode(&insn_nopl3);
> > +       exec_in_big_real_mode(&insn_nopl4);
> > +       exec_in_big_real_mode(&insn_nopl5);
> > +       exec_in_big_real_mode(&insn_nopl6);
> > +       exec_in_big_real_mode(&insn_nopl7);
> > +       exec_in_big_real_mode(&insn_nopl8);
> > +       exec_in_big_real_mode(&insn_nopl9);
> > +       report("nopl", 0, 1);
> > +}
> > +
> >  void realmode_start(void)
> >  {
> >         test_null();
> > @@ -1548,6 +1571,7 @@ void realmode_start(void)
> >         test_xlat();
> >         test_salc();
> >         test_fninit();
> > +       test_nopl();
> >
> >         exit(0);
> >  }
> > --
> > 1.7.9.5
> >
>=20
>=20
>=20
> --=20
> Arthur Chunqi Li
> Department of Computer Science
> School of EECS
> Peking University
> Beijing, China

--
			Gleb.