All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] i2c: Let users disable "Probe an I2C bus for certain devices"
Date: Fri, 7 Jun 2013 11:06:23 +0200	[thread overview]
Message-ID: <20130607090623.GC3428@katana> (raw)
In-Reply-To: <51AF63C7.9070007@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]


> 3) Thinking about Mainline: To reach the same target - no I2C
> detection - and taking
> into account above assumption "No changes in default behavior"
> the following will need to be done:
> - change i2c-omap/i2c-gpio DT bindings and add parameter which will
> allow to change
>   .class value for adapter. Not sure, it's possible because this parameter
>   will be Linux and not HW specific (smth. like "i2c_disable_detection")
> - update drivers i2c-omap/i2c-gpio to use "i2c_disable_detection"
> - update OMAP4/5 DTS files
> 
> So, It seemed a good solution for me to add 6 lines of code in i2c-core.c
> instead of doing all that stuff.

Well... I understand the "default behaviour" issue, yet I still think
that setting class to 0 is the right thing to do. OMAP is an embedded
SoC which always had i2c_board_info or devictree which are the preferred
ways of instantiating. Given that, I would accept a patch setting it to
0. The more user friendly way might be to introduce a new class which
makes users aware of the issue. Proof of concept follows, only compile
tested.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-06-07  9:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 17:33 [PATCH] i2c: Let users disable "Probe an I2C bus for certain devices" Grygorii Strashko
2013-06-04 17:33 ` Grygorii Strashko
2013-06-04 17:49 ` Wolfram Sang
2013-06-04 17:49   ` Wolfram Sang
2013-06-05 16:13   ` Grygorii Strashko
2013-06-05 16:13     ` Grygorii Strashko
2013-06-07  9:06     ` Wolfram Sang [this message]
2013-06-07  9:09       ` [RFC] i2c: add deprecation warning for class based instantiation Wolfram Sang
2013-06-19 10:15         ` Wolfram Sang
2013-06-19 10:15           ` Wolfram Sang
2013-06-19 18:21           ` Grygorii Strashko
2013-06-19 18:21             ` Grygorii Strashko
2013-06-20 18:37             ` Wolfram Sang
2013-06-19 18:22         ` Grygorii Strashko
2013-06-19 18:22           ` Grygorii Strashko
2013-06-19 18:22         ` [RFC 1/2] i2c: omap: drop class based instantiation of slaves Grygorii Strashko
2013-06-19 18:22           ` Grygorii Strashko
2013-06-19 18:22           ` [RFC 2/2] i2c: gpio: " Grygorii Strashko
2013-06-19 18:22             ` Grygorii Strashko
2013-06-07 10:10       ` [PATCH] i2c: Let users disable "Probe an I2C bus for certain devices" Grygorii Strashko
2013-06-07 10:10         ` Grygorii Strashko
2013-06-07 21:28         ` Wolfram Sang
2013-06-07 21:28           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607090623.GC3428@katana \
    --to=wsa@the-dreams.de \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.