From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 1/9] dma: pl330: rip out broken, redundant ID probing Date: Tue, 11 Jun 2013 09:45:14 +0100 Message-ID: <20130611084514.GA24729@mudshark.cambridge.arm.com> References: <1370889285-22799-1-git-send-email-will.deacon@arm.com> <1370889285-22799-2-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jassi Brar Cc: Vinod Koul , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , device-tree , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Jun 11, 2013 at 05:40:36AM +0100, Jassi Brar wrote: > On 11 June 2013 00:04, Will Deacon wrote: > > The PL330 driver probes the peripheral and primecell IDs of the device to > > make sure that it is indeed an AMBA PL330. However, it does this by > > making byte accesses to a device mapping of the word-aligned ID > > registers, which is either UNPREDICTABLE or generates an alignment fault > > (depending on the presence of the virtualisation extensions). > > > > Rather than fix this code, we can actually rip most of it out and let > > the AMBA bus driver correctly do the probing for us. > > > Acked-by: Jassi Brar Thanks for the acks Jassi! Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 11 Jun 2013 09:45:14 +0100 Subject: [PATCH 1/9] dma: pl330: rip out broken, redundant ID probing In-Reply-To: References: <1370889285-22799-1-git-send-email-will.deacon@arm.com> <1370889285-22799-2-git-send-email-will.deacon@arm.com> Message-ID: <20130611084514.GA24729@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 11, 2013 at 05:40:36AM +0100, Jassi Brar wrote: > On 11 June 2013 00:04, Will Deacon wrote: > > The PL330 driver probes the peripheral and primecell IDs of the device to > > make sure that it is indeed an AMBA PL330. However, it does this by > > making byte accesses to a device mapping of the word-aligned ID > > registers, which is either UNPREDICTABLE or generates an alignment fault > > (depending on the presence of the virtualisation extensions). > > > > Rather than fix this code, we can actually rip most of it out and let > > the AMBA bus driver correctly do the probing for us. > > > Acked-by: Jassi Brar Thanks for the acks Jassi! Will