From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754401Ab3FQSRJ (ORCPT ); Mon, 17 Jun 2013 14:17:09 -0400 Received: from mail.skyhub.de ([78.46.96.112]:45536 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863Ab3FQSRG (ORCPT ); Mon, 17 Jun 2013 14:17:06 -0400 Date: Mon, 17 Jun 2013 20:17:02 +0200 From: Borislav Petkov To: Randy Dunlap Cc: Srinivas Pandruvada , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Linux PM list Subject: Re: [PATCH -next v2] thermal: fix x86_pkg_temp_thermal.c build and Kconfig Message-ID: <20130617181702.GA7217@pd.tnic> References: <20130617185106.5950ffbf4b96acd9b2b2c834@canb.auug.org.au> <51BF4159.1000004@infradead.org> <51BF46C3.3090900@linux.intel.com> <51BF4DA2.40601@infradead.org> <51BF50E3.9000806@linux.intel.com> <51BF5174.805@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51BF5174.805@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2013 at 11:12:04AM -0700, Randy Dunlap wrote: > On 06/17/13 11:09, Srinivas Pandruvada wrote: > > Sorry for this issue. I was about to submit a patch for this, > > > > You should change to > > > > depends on X86 && X86_MCE && X86_THERMAL_VECTOR > > --- > From: Randy Dunlap > > Fix build error in x86_pkg_temp_thermal.c. It requires that > X86_MCE be enabled, so depend on that symbol. > Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block, > so remove that duplicated dependency. > > ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! > ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined! > > Signed-off-by: Randy Dunlap > --- > drivers/thermal/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- linux-next-20130617.orig/drivers/thermal/Kconfig > +++ linux-next-20130617/drivers/thermal/Kconfig > @@ -171,8 +171,7 @@ config INTEL_POWERCLAMP > > config X86_PKG_TEMP_THERMAL > tristate "X86 package temperature thermal driver" > - depends on THERMAL > - depends on X86 > + depends on X86 && X86_MCE && X86_THERMAL_VECTOR X86_THERMAL_VECTOR depends on X86_MCE_INTEL which depends on X86_MCE. So depends on X86_THERMAL_VECTOR should be enough, IMO. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --