From: Dave Chinner <david@fromorbit.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly
Date: Wed, 19 Jun 2013 09:13:14 +1000 [thread overview]
Message-ID: <20130618231314.GC29338@dastard> (raw)
In-Reply-To: <51C0E5BC.6060809@oracle.com>
On Tue, Jun 18, 2013 at 05:57:00PM -0500, Dave Kleikamp wrote:
> The retval parameter to pthread_join() is a pointer to a pointer.
> aio-stress is passing in a pointer to an int. This can result in a bus
> error on sparc64 when the pointer is not aligned on a 64-bit boundary.
> Since the return value is not used, it is simplest to pass a NULL
> pointer instead.
>
> This has been fixed in the LTP source:
> https://github.com/linux-test-project/ltp/commit/981d33aad3b33c4625b88990fbf2fad5470d47e0
>
> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Looks good. Thanks, Shaggy.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-18 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 22:57 [PATCH] xfstests: aio-stress is calling pthread_join incorrectly Dave Kleikamp
2013-06-18 23:13 ` Dave Chinner [this message]
2013-06-26 16:22 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618231314.GC29338@dastard \
--to=david@fromorbit.com \
--cc=dave.kleikamp@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.