From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UpJLk-0005HY-6V
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:27:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UpJLf-0005Yi-Q5
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:27:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46823)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UpJLf-0005YW-Gu
	for qemu-devel@nongnu.org; Wed, 19 Jun 2013 10:26:59 -0400
Date: Wed, 19 Jun 2013 16:26:55 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130619142655.GB4586@stefanha-thinkpad.muc.redhat.com>
References: <1371209999-15579-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1371209999-15579-13-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130618143212.GP7649@stefanha-thinkpad.redhat.com>
	<51C14DEB.4050702@linux.vnet.ibm.com>
	<20130619074649.GD23822@stefanha-thinkpad.muc.redhat.com>
	<51C1736F.9070401@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <51C1736F.9070401@linux.vnet.ibm.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal
 snapshot for block device test case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, famz@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com, dietmar@proxmox.com

On Wed, Jun 19, 2013 at 05:01:35PM +0800, Wenchao Xia wrote:
> > On Wed, Jun 19, 2013 at 02:21:31PM +0800, Wenchao Xia wrote:
> >>=E4=BA=8E 2013-6-18 22:32, Stefan Hajnoczi =E5=86=99=E9=81=93:
> >>>On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote:
> >>>>+    def createSnapshotInTransaction(self, snapshot_num):
> >>>>+        actions =3D []
> >>>>+        for i in range(0, len(self.expect)):
> >>>>+            num =3D self.expect[i]['snapshots_name_counter']
> >>>>+            for j in range(0, snapshot_num):
> >>>>+                name =3D '%s_sn%d' % (self.expect[i]['device'], nu=
m)
> >>>>+                num =3D num + 1
> >>>>+                self.expect[i]['snapshots'].append(name)
> >>>>+                actions.append({
> >>>>+                    'type': 'blockdev-snapshot-internal-sync',
> >>>>+                    'data': { 'device': self.expect[i]['device'],
> >>>>+                              'name': name },
> >>>>+                })
> >>>>+            self.expect[i]['snapshots_name_counter'] =3D num
> >>>>+        result =3D self.vm.qmp('transaction', actions =3D actions)
> >>>>+        self.assert_qmp(result, 'return', {})
> >>>
> >>>This tests the success case.  Please also use the 'Abort' action to =
test
> >>>the error case.
> >>   Is "Abort" upstreamed? If yes I will add that part.
> >
> >It's part of the drive-backup series which you have already
> >cherry-picked from.
> >
>   Will you continue work on drive-backup? I'd like to rebase this
> serial after your v6, to reduce conflict.

Yep, I'll send another revision soon.  Kevin has been reviewing it
today.

Stefan