From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 168BD7F37 for ; Fri, 21 Jun 2013 08:44:06 -0500 (CDT) Date: Fri, 21 Jun 2013 08:44:02 -0500 From: Geoffrey Wehrman Subject: Re: [PATCH 39/48] mkfs.xfs: validate options for CRCs up front. Message-ID: <20130621134401.GA18807@sgi.com> References: <1370564771-4929-1-git-send-email-david@fromorbit.com> <1370564771-4929-40-git-send-email-david@fromorbit.com> <20130620211747.GB7800@sgi.com> <20130620230534.GV29376@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130620230534.GV29376@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jun 21, 2013 at 09:05:34AM +1000, Dave Chinner wrote: | On Thu, Jun 20, 2013 at 04:17:47PM -0500, Geoffrey Wehrman wrote: | > On Fri, Jun 07, 2013 at 10:26:02AM +1000, Dave Chinner wrote: | > | From: Dave Chinner | > | | > | With CRC enabled filesystems, certain options are now not optional | > | and so are always enabled. Validate these options up front and | > | abort if options are specified that cannot be set. | > | | > | Signed-off-by: Dave Chinner | > | --- | > | mkfs/xfs_mkfs.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++----- | > | 1 file changed, 56 insertions(+), 5 deletions(-) | > | | > | diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c | > | index 291bab4..9987dde 100644 | > | --- a/mkfs/xfs_mkfs.c | > | +++ b/mkfs/xfs_mkfs.c | > ... | > | @@ -1754,6 +1754,57 @@ _("block size %d cannot be smaller than logical sector size %d\n"), | > | logversion = 2; | > | } | > | | > | + /* | > | + * Now we have blocks and sector sizes set up, check parameters that are | > | + * no longer optional for CRC enabled filesystems. Catch them up front | > | + * here before doing anything else. | > | + */ | > | + if (crcs_enabled) { | > | + /* minimum inode size is 512 bytes, ipflag checked later */ | > | + if ((isflag || ilflag) && inodelog < XFS_DINODE_DFL_CRC_LOG) { | > | + fprintf(stderr, | > | +_("Minimum inode size for CRCs is %d bytes\n"), | > | + 1 << XFS_DINODE_DFL_CRC_LOG); | > | + usage(); | > | + } | > | > I am not satisfied with the explanation for not allowing 256 byte inodes | > with CRCs, and I am requesting that this limitation not be implemented. | > I have no issue with making the default inode size 512 bytes, but | > removing the option for 256 byte inodes is an issue, especially with the | > initial implementation. Making the minimum inode size 256 is fine. | | IOWs, there's nothing to debate - 256 byte inodes in v3 format is | not physically possible with the current on-disk format | definitions... I should have done the math. I didn't realize how bloated v4 inodes are. -- Geoffrey Wehrman 651-683-5496 gwehrman@sgi.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs