From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/6] drm/i915: Clean up VLV rps code a bit
Date: Tue, 25 Jun 2013 11:59:11 -0700
Message-ID: <20130625115911.5733573e@jbarnes-desktop>
References: <1372177266-2665-1-git-send-email-ville.syrjala@linux.intel.com>
	<1372177266-2665-2-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy13-pub.unifiedlayer.com (oproxy13-pub.unifiedlayer.com
	[69.89.16.30])
	by gabe.freedesktop.org (Postfix) with SMTP id 76E63E5C41
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 25 Jun 2013 11:57:10 -0700 (PDT)
In-Reply-To: <1372177266-2665-2-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAyNSBKdW4gMjAxMyAxOToyMTowMSArMDMwMAp2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbSB3cm90ZToKCj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp
bnV4LmludGVsLmNvbT4KPiAKPiBBbHdheXMgcHJpbnQgYm90aCB0aGUgTUh6IHZhbHVlIGFuZCBy
YXcgcmVnaXN0ZXIgdmFsdWUgZm9yIHJwcyBzdHVmZi4KPiAKPiBBbHNvIGtpbGwgYSBzb21ld2hh
dCBwb2ludGxlc3MgbG9jYWwgJ3JwZScgdmFyaWFibGUgYW5kIGp1c3QgdXNlCj4gZGV2X3ByaXYt
PnJwcy5ycGVfZGVsYXkuCj4gCj4gV2hpbGUgYXQgaXQgY2xlYW4gdXAgdGhlIGNhcHMgaW4gIkdQ
VSIgYW5kICJQdW5pdCIgZGVidWcgbWVzc2FnZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDUwICsrKysrKysrKysrKysrKysrKysrKysrKy0t
LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAyMCBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
cG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCAzNzA1MjAzLi40
OGEzMTYyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gQEAgLTMwNzcsMTAgKzMwNzcs
MTEgQEAgdm9pZCB2YWxsZXl2aWV3X3NldF9ycHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdTgg
dmFsKQo+ICAJV0FSTl9PTih2YWwgPiBkZXZfcHJpdi0+cnBzLm1heF9kZWxheSk7Cj4gIAlXQVJO
X09OKHZhbCA8IGRldl9wcml2LT5ycHMubWluX2RlbGF5KTsKPiAgCj4gLQlEUk1fREVCVUdfRFJJ
VkVSKCJncHUgZnJlcSByZXF1ZXN0IGZyb20gJWQgdG8gJWRcbiIsCj4gKwlEUk1fREVCVUdfRFJJ
VkVSKCJHUFUgZnJlcSByZXF1ZXN0IGZyb20gJWQgTUh6ICgldSkgdG8gJWQgTUh6ICgldSlcbiIs
Cj4gIAkJCSB2bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLAo+ICAJCQkJICAgICAgZGV2
X3ByaXYtPnJwcy5jdXJfZGVsYXkpLAo+IC0JCQkgdmx2X2dwdV9mcmVxKGRldl9wcml2LT5tZW1f
ZnJlcSwgdmFsKSk7Cj4gKwkJCSBkZXZfcHJpdi0+cnBzLmN1cl9kZWxheSwKPiArCQkJIHZsdl9n
cHVfZnJlcShkZXZfcHJpdi0+bWVtX2ZyZXEsIHZhbCksIHZhbCk7Cj4gIAo+ICAJaWYgKHZhbCA9
PSBkZXZfcHJpdi0+cnBzLmN1cl9kZWxheSkKPiAgCQlyZXR1cm47Cj4gQEAgLTMwOTgsOCArMzA5
OSw5IEBAIHZvaWQgdmFsbGV5dmlld19zZXRfcnBzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHU4
IHZhbCkKPiAgCj4gIAlwdmFsID0gdmx2X3B1bml0X3JlYWQoZGV2X3ByaXYsIFBVTklUX1JFR19H
UFVfRlJFUV9TVFMpOwo+ICAJaWYgKChwdmFsID4+IDgpICE9IHZhbCkKPiAtCQlEUk1fREVCVUdf
RFJJVkVSKCJwdW5pdCBvdmVycm9kZSBmcmVxOiAlZCByZXF1ZXN0ZWQsIGJ1dCBnb3QgJWRcbiIs
Cj4gLQkJCSAgdmFsLCBwdmFsID4+IDgpOwo+ICsJCURSTV9ERUJVR19EUklWRVIoIlB1bml0IG92
ZXJyb2RlIEdQVSBmcmVxOiAlZCBNSHogKCV1KSByZXF1ZXN0ZWQsIGJ1dCBnb3QgJWQgTWh6ICgl
dSlcbiIsCj4gKwkJCQkgdmx2X2dwdV9mcmVxKGRldl9wcml2LT5tZW1fZnJlcSwgdmFsKSwgdmFs
LAo+ICsJCQkJIHZsdl9ncHVfZnJlcShkZXZfcHJpdi0+bWVtX2ZyZXEsIHB2YWwgPj4gOCksIHB2
YWwgPj4gOCk7Cj4gIAo+ICAJLyogTWFrZSBzdXJlIHdlIGNvbnRpbnVlIHRvIGdldCBpbnRlcnJ1
cHRzCj4gIAkgKiB1bnRpbCB3ZSBoaXQgdGhlIG1pbmltdW0gb3IgbWF4aW11bSBmcmVxdWVuY2ll
cy4KPiBAQCAtMzQ5Myw3ICszNDk1LDcgQEAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19lbmFibGVf
cnBzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlzdHJ1Y3QgaW50ZWxfcmluZ19i
dWZmZXIgKnJpbmc7Cj4gLQl1MzIgZ3RmaWZvZGJnLCB2YWwsIHJwZTsKPiArCXUzMiBndGZpZm9k
YmcsIHZhbDsKPiAgCWludCBpOwo+ICAKPiAgCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgmZGV2
X3ByaXYtPnJwcy5od19sb2NrKSk7Cj4gQEAgLTM1NTQsMzEgKzM1NTYsMzkgQEAgc3RhdGljIHZv
aWQgdmFsbGV5dmlld19lbmFibGVfcnBzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlEUk1f
REVCVUdfRFJJVkVSKCJHUExMIGVuYWJsZWQ/ICVzXG4iLCB2YWwgJiAweDEwID8gInllcyIgOiAi
bm8iKTsKPiAgCURSTV9ERUJVR19EUklWRVIoIkdQVSBzdGF0dXM6IDB4JTA4eFxuIiwgdmFsKTsK
PiAgCj4gLQlEUk1fREVCVUdfRFJJVkVSKCJjdXJyZW50IEdQVSBmcmVxOiAlZFxuIiwKPiAtCQkJ
IHZsdl9ncHVfZnJlcShkZXZfcHJpdi0+bWVtX2ZyZXEsICh2YWwgPj4gOCkgJiAweGZmKSk7Cj4g
IAlkZXZfcHJpdi0+cnBzLmN1cl9kZWxheSA9ICh2YWwgPj4gOCkgJiAweGZmOwo+ICsJRFJNX0RF
QlVHX0RSSVZFUigiY3VycmVudCBHUFUgZnJlcTogJWQgTUh6ICgldSlcbiIsCj4gKwkJCSB2bHZf
Z3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLAo+ICsJCQkJICAgICAgZGV2X3ByaXYtPnJwcy5j
dXJfZGVsYXkpLAo+ICsJCQkgZGV2X3ByaXYtPnJwcy5jdXJfZGVsYXkpOwo+ICAKPiAgCWRldl9w
cml2LT5ycHMubWF4X2RlbGF5ID0gdmFsbGV5dmlld19ycHNfbWF4X2ZyZXEoZGV2X3ByaXYpOwo+
ICAJZGV2X3ByaXYtPnJwcy5od19tYXggPSBkZXZfcHJpdi0+cnBzLm1heF9kZWxheTsKPiAtCURS
TV9ERUJVR19EUklWRVIoIm1heCBHUFUgZnJlcTogJWRcbiIsIHZsdl9ncHVfZnJlcShkZXZfcHJp
di0+bWVtX2ZyZXEsCj4gLQkJCQkJCSAgICAgZGV2X3ByaXYtPnJwcy5tYXhfZGVsYXkpKTsKPiAr
CURSTV9ERUJVR19EUklWRVIoIm1heCBHUFUgZnJlcTogJWQgTUh6ICgldSlcbiIsCj4gKwkJCSB2
bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLAo+ICsJCQkJICAgICAgZGV2X3ByaXYtPnJw
cy5tYXhfZGVsYXkpLAo+ICsJCQkgZGV2X3ByaXYtPnJwcy5tYXhfZGVsYXkpOwo+ICAKPiAtCXJw
ZSA9IHZhbGxleXZpZXdfcnBzX3JwZV9mcmVxKGRldl9wcml2KTsKPiAtCURSTV9ERUJVR19EUklW
RVIoIlJQZSBHUFUgZnJlcTogJWRcbiIsCj4gLQkJCSB2bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1l
bV9mcmVxLCBycGUpKTsKPiAtCWRldl9wcml2LT5ycHMucnBlX2RlbGF5ID0gcnBlOwo+ICsJZGV2
X3ByaXYtPnJwcy5ycGVfZGVsYXkgPSB2YWxsZXl2aWV3X3Jwc19ycGVfZnJlcShkZXZfcHJpdik7
Cj4gKwlEUk1fREVCVUdfRFJJVkVSKCJSUGUgR1BVIGZyZXE6ICVkIE1IeiAoJXUpXG4iLAo+ICsJ
CQkgdmx2X2dwdV9mcmVxKGRldl9wcml2LT5tZW1fZnJlcSwKPiArCQkJCSAgICAgIGRldl9wcml2
LT5ycHMucnBlX2RlbGF5KSwKPiArCQkJIGRldl9wcml2LT5ycHMucnBlX2RlbGF5KTsKPiAgCj4g
LQl2YWwgPSB2YWxsZXl2aWV3X3Jwc19taW5fZnJlcShkZXZfcHJpdik7Cj4gLQlEUk1fREVCVUdf
RFJJVkVSKCJtaW4gR1BVIGZyZXE6ICVkXG4iLCB2bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9m
cmVxLAo+IC0JCQkJCQkJICAgIHZhbCkpOwo+IC0JZGV2X3ByaXYtPnJwcy5taW5fZGVsYXkgPSB2
YWw7Cj4gKwlkZXZfcHJpdi0+cnBzLm1pbl9kZWxheSA9IHZhbGxleXZpZXdfcnBzX21pbl9mcmVx
KGRldl9wcml2KTsKPiArCURSTV9ERUJVR19EUklWRVIoIm1pbiBHUFUgZnJlcTogJWQgTUh6ICgl
dSlcbiIsCj4gKwkJCSB2bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLAo+ICsJCQkJICAg
ICAgZGV2X3ByaXYtPnJwcy5taW5fZGVsYXkpLAo+ICsJCQkgZGV2X3ByaXYtPnJwcy5taW5fZGVs
YXkpOwo+ICAKPiAtCURSTV9ERUJVR19EUklWRVIoInNldHRpbmcgR1BVIGZyZXEgdG8gJWRcbiIs
Cj4gLQkJCSB2bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLCBycGUpKTsKPiArCURSTV9E
RUJVR19EUklWRVIoInNldHRpbmcgR1BVIGZyZXEgdG8gJWQgTUh6ICgldSlcbiIsCj4gKwkJCSB2
bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLAo+ICsJCQkJICAgICAgZGV2X3ByaXYtPnJw
cy5ycGVfZGVsYXkpLAo+ICsJCQkgZGV2X3ByaXYtPnJwcy5ycGVfZGVsYXkpOwo+ICAKPiAgCUlO
SVRfREVMQVlFRF9XT1JLKCZkZXZfcHJpdi0+cnBzLnZsdl93b3JrLCB2bHZfcnBzX3RpbWVyX3dv
cmspOwo+ICAKPiAtCXZhbGxleXZpZXdfc2V0X3JwcyhkZXZfcHJpdi0+ZGV2LCBycGUpOwo+ICsJ
dmFsbGV5dmlld19zZXRfcnBzKGRldl9wcml2LT5kZXYsIGRldl9wcml2LT5ycHMucnBlX2RlbGF5
KTsKPiAgCj4gIAkvKiByZXF1aXJlcyBNU0kgZW5hYmxlZCAqLwo+ICAJSTkxNV9XUklURShHRU42
X1BNSUVSLCBHRU42X1BNX1JQU19FVkVOVFMpOwoKUmV2aWV3ZWQtYnk6IEplc3NlIEJhcm5lcyA8
amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgoKLS0gCkplc3NlIEJhcm5lcywgSW50ZWwgT3BlbiBT
b3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m
by9pbnRlbC1nZngK