Re: [PATCH 09/10] x86: check kexec relocation code fits in a page

From: Daniel Kiper <daniel.kiper@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
Subject: Re: [PATCH 09/10] x86: check kexec relocation code fits in a page
Date: Tue, 25 Jun 2013 21:00:59 +0200	[thread overview]
Message-ID: <20130625190059.GB10322@debian70-amd64.local.net-space.pl> (raw)
In-Reply-To: <1372095741-27012-10-git-send-email-david.vrabel@citrix.com>

On Mon, Jun 24, 2013 at 06:42:20PM +0100, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> The kexec relocation (control) code must fit in a single page so add a
> link time check for this.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> ---
>  xen/arch/x86/xen.lds.S |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index d959941..eebed01 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -186,3 +186,7 @@ SECTIONS
>    .stab.indexstr 0 : { *(.stab.indexstr) }
>    .comment 0 : { *(.comment) }
>  }
> +
> +#ifdef CONFIG_KEXEC
> +ASSERT(__kexec_reloc_size <= PAGE_SIZE, "kexec control code is too large")

ASSERT(kexec_reloc_size <= KEXEC_CONTROL_PAGE_SIZE, "kexec control code is too large")

Daniel