From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: Re: [PATCHv6 0/10] kexec: extend kexec hypercall for use with pv-ops kernels Date: Tue, 25 Jun 2013 21:27:10 +0200 Message-ID: <20130625192710.GC10322@debian70-amd64.local.net-space.pl> References: <1372095741-27012-1-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1372095741-27012-1-git-send-email-david.vrabel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Jun 24, 2013 at 06:42:11PM +0100, David Vrabel wrote: [...] > Changes since v4 (v5 was not posted to the list): > > - _rsvd -> _pad in one of the public ABI structures. > - Fix bug where trailing pages were not zeroed. This fixes loading a > 64-bit Linux kernel using a more recent version of kexec-tools. Why? I do not see why trailing pages must be zeroed. I am afraid that this way you are only masking bug in kexec-tools. I think it is better to do bisect on it and find out which patch introduces a bug. In general this series is OK but as I can see Jan has some comments this time. I think that it is worth to take most of them into account. Please prepare next version of these patches and repost with kexec-tools patches. They are integral part of new Xen kexec implementation and it is worth to review both patch series together. Daniel PS I will be on holiday next week and I would not be able to do reviews.