All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Wang YanQing <udknight@gmail.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
	x86@kernel.org, bp@suse.de, fenghua.yu@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Fix override new_cpu_data.x86 with 486
Date: Thu, 27 Jun 2013 12:54:35 +0200	[thread overview]
Message-ID: <20130627105435.GA21297@pd.tnic> (raw)
In-Reply-To: <20130626162640.GA19913@udknight>

On Thu, Jun 27, 2013 at 12:26:40AM +0800, Wang YanQing wrote:
> 
> We should set X86 to 486 before use cpuid
> to detect the cpu type, if we set X86 to 486
> after cpuid, then we will get 486 for ever.

So not "for ever" but until cpu_detect runs.

> 
> Yes, we will correct this in early_cpu_init,
> but it is still a wrong behavior, right? So
> just fix it.

Right, so this patch is correct and it fixes the small window where we
run with family == 4 before cpu_detect but the commit message needs a
bit massaging before it gets applied.

> 
> I also find maybe we can delete the new_cpu_data,
> because we will over write all the information
> in early_cpu_init, and before early_cpu_init,
> there is no user of new_cpu_data, but this is
> another patch in the future.

You can drop that part.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  parent reply	other threads:[~2013-06-27 10:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 16:26 [PATCH] x86: Fix override new_cpu_data.x86 with 486 Wang YanQing
2013-06-26 16:56 ` Borislav Petkov
2013-06-27 10:54 ` Borislav Petkov [this message]
2013-06-28  0:56   ` Wang YanQing
2013-06-28  8:51     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627105435.GA21297@pd.tnic \
    --to=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=udknight@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.