From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "linux-media" <linux-media@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] usbtv: fix dependency
Date: Fri, 28 Jun 2013 08:00:43 -0300 [thread overview]
Message-ID: <20130628080043.46dd09c0.mchehab@redhat.com> (raw)
In-Reply-To: <201306281024.15428.hverkuil@xs4all.nl>
Em Fri, 28 Jun 2013 10:24:15 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> This fixes a dependency problem as found by Randy Dunlap:
>
> https://lkml.org/lkml/2013/6/27/501
>
> Mauro, is there any reason for any V4L2 driver to depend on VIDEO_DEV instead of
> just VIDEO_V4L2?
>
> Some drivers depend on VIDEO_DEV, some on VIDEO_V4L2, some on both. It's all
> pretty chaotic.
It should be noticed that, despite its name, this config is actually a
joint dependency of VIDEO_DEV and I2C that will compile drivers as module
if either I2C or VIDEO_DEV is a module:
config VIDEO_V4L2
tristate
depends on (I2C || I2C=n) && VIDEO_DEV
default (I2C || I2C=n) && VIDEO_DEV
So, a V4L2 device that doesn't have any I2C device doesn't need to depend
on VIDEO_V4L2. That includes, for example, reversed-engineered webcam
drivers where the sensor code is inside the driver and a few capture-only
device drivers.
It should be noticed, however, that, on several places, the need of adding
a "depends on VIDEO_V4L2" is not needed, as, on some places, the syntax
is:
if VIDEO_V4L2
config "driver foo"
...
endif
Btw, it could make sense to rename it to something clearer, like
VIDEO_DEV_AND_I2C and define it as:
config VIDEO_DEV_AND_I2C
tristate
depends on I2C && VIDEO_DEV
default y
Or, even better, to just get rid of it and explicitly add I2C on all
places where it is used.
Regards,
Mauro
>
> Regards,
>
> Hans
>
> diff --git a/drivers/media/usb/usbtv/Kconfig b/drivers/media/usb/usbtv/Kconfig
> index 8864436..7c5b860 100644
> --- a/drivers/media/usb/usbtv/Kconfig
> +++ b/drivers/media/usb/usbtv/Kconfig
> @@ -1,6 +1,6 @@
> config VIDEO_USBTV
> tristate "USBTV007 video capture support"
> - depends on VIDEO_DEV
> + depends on VIDEO_V4L2
> select VIDEOBUF2_VMALLOC
>
> ---help---
--
Cheers,
Mauro
next prev parent reply other threads:[~2013-06-28 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 8:24 [PATCH] usbtv: fix dependency Hans Verkuil
2013-06-28 11:00 ` Mauro Carvalho Chehab [this message]
2013-06-28 11:18 ` Hans Verkuil
2013-06-28 12:42 ` Mauro Carvalho Chehab
2013-06-28 12:59 ` Hans Verkuil
2013-06-28 13:24 ` Guennadi Liakhovetski
2013-06-28 13:55 ` Mauro Carvalho Chehab
2013-06-28 14:15 ` Hans Verkuil
2013-06-28 15:32 ` Mauro Carvalho Chehab
2013-06-28 17:54 ` Mauro Carvalho Chehab
2013-07-03 17:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628080043.46dd09c0.mchehab@redhat.com \
--to=mchehab@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.