From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Intel Graphics <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Don't wait for vblank for sprite plane flips
Date: Fri, 28 Jun 2013 17:05:18 +0100 [thread overview]
Message-ID: <20130628160518.GD32183@cantiga.alporthouse.com> (raw)
In-Reply-To: <20130628142450.GH5004@intel.com>
On Fri, Jun 28, 2013 at 05:24:50PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 28, 2013 at 07:45:31PM +0530, Vijay Purushothaman wrote:
> > Since the sprite planes are using synchronized MMIO based flip, no need
> > to wait for vblank. Removing this wait allows us to get a nice
> > performance boost to both 3D & media workloads based on sprite (~60 fps
> > from ~20 fps)
>
> Nak. We can't unpin the buffer until the hardware has finished reading
> from it.
>
> The proper fix is to do the unpin asynchronously after the flip has
> completed. That's one part of the bigger atomic pageflip story.
The interested reader is invited to review the patches to do async
unpinning here and in set-base sent many, many moons ago.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-06-28 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 14:15 [PATCH] drm/i915: Don't wait for vblank for sprite plane flips Vijay Purushothaman
2013-06-28 14:22 ` Kumar, Shobhit
2013-06-28 14:24 ` Ville Syrjälä
2013-06-28 16:05 ` Chris Wilson [this message]
2013-07-01 5:28 ` Vijay Purushothaman
2013-07-01 5:26 ` Vijay Purushothaman
2013-07-01 8:20 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628160518.GD32183@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.