From: Pavel Machek <pavel@ucw.cz> To: Tony Lindgren <tony@atomide.com> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>, pali.rohar@gmail.com, kernel list <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap@vger.kernel.org Subject: [PATCH] N900: fix operation on emulator Date: Mon, 1 Jul 2013 16:03:20 +0200 [thread overview] Message-ID: <20130701140315.GA15318@amd.pavel.ucw.cz> (raw) In-Reply-To: <20130617111031.GQ20992@atomide.com> Errata workarounds for N900 hardware actually break operation on emulator. Fix it. This approach was suggested by Pali Rohár <pali.rohar@gmail.com> (thanks!). (Also explain what "sleep_ind" led actually does). Signed-off-by: Pavel Machek <pavel@ucw.cz> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c index 74f83a5..81f7b9f 100644 --- a/arch/arm/mach-omap2/board-rx51.c +++ b/arch/arm/mach-omap2/board-rx51.c @@ -33,9 +33,12 @@ #include "pm.h" #include "sdram-nokia.h" #include "board-rx51-secure.h" +#include "soc.h" #define RX51_GPIO_SLEEP_IND 162 +/* This lights up left part of keyboard */ + static struct gpio_led gpio_leds[] = { { .name = "sleep_ind", @@ -107,9 +110,11 @@ static void __init rx51_init(void) rx51_camera_init(); #ifdef CONFIG_ARM_ERRATA_430973 - printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); - /* set IBE to 1 */ - rx51_secure_update_aux_cr(1 << 6, 0); + if (omap_type() == OMAP2_DEVICE_TYPE_SEC) { + printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); + /* set IBE to 1 */ + rx51_secure_update_aux_cr(1 << 6, 0); + } #endif /* Ensure SDRC pins are mux'd for self-refresh */ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] N900: fix operation on emulator Date: Mon, 1 Jul 2013 16:03:20 +0200 [thread overview] Message-ID: <20130701140315.GA15318@amd.pavel.ucw.cz> (raw) In-Reply-To: <20130617111031.GQ20992@atomide.com> Errata workarounds for N900 hardware actually break operation on emulator. Fix it. This approach was suggested by Pali Roh?r <pali.rohar@gmail.com> (thanks!). (Also explain what "sleep_ind" led actually does). Signed-off-by: Pavel Machek <pavel@ucw.cz> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c index 74f83a5..81f7b9f 100644 --- a/arch/arm/mach-omap2/board-rx51.c +++ b/arch/arm/mach-omap2/board-rx51.c @@ -33,9 +33,12 @@ #include "pm.h" #include "sdram-nokia.h" #include "board-rx51-secure.h" +#include "soc.h" #define RX51_GPIO_SLEEP_IND 162 +/* This lights up left part of keyboard */ + static struct gpio_led gpio_leds[] = { { .name = "sleep_ind", @@ -107,9 +110,11 @@ static void __init rx51_init(void) rx51_camera_init(); #ifdef CONFIG_ARM_ERRATA_430973 - printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); - /* set IBE to 1 */ - rx51_secure_update_aux_cr(1 << 6, 0); + if (omap_type() == OMAP2_DEVICE_TYPE_SEC) { + printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); + /* set IBE to 1 */ + rx51_secure_update_aux_cr(1 << 6, 0); + } #endif /* Ensure SDRC pins are mux'd for self-refresh */ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-07-01 14:03 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-09 1:59 N900 device tree conversion: how to do first step Pavel Machek 2013-06-09 1:59 ` Pavel Machek 2013-06-09 9:24 ` Pali Rohár 2013-06-09 9:24 ` Pali Rohár 2013-06-09 16:47 ` Pavel Machek 2013-06-09 16:47 ` Pavel Machek 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:30 ` Pavel Machek 2013-06-09 17:30 ` Pavel Machek 2013-06-09 20:11 ` Aaro Koskinen 2013-06-09 20:11 ` Aaro Koskinen 2013-06-13 13:26 ` Pavel Machek 2013-06-13 13:26 ` Pavel Machek 2013-06-13 14:10 ` Tony Lindgren 2013-06-13 14:10 ` Tony Lindgren 2013-06-13 14:28 ` Pavel Machek 2013-06-13 14:28 ` Pavel Machek 2013-06-13 14:57 ` Tony Lindgren 2013-06-13 14:57 ` Tony Lindgren 2013-06-13 15:52 ` Pavel Machek 2013-06-13 15:52 ` Pavel Machek 2013-06-13 16:14 ` Tony Lindgren 2013-06-13 16:14 ` Tony Lindgren 2013-06-13 23:08 ` Pavel Machek 2013-06-13 23:08 ` Pavel Machek 2013-06-14 5:56 ` Tony Lindgren 2013-06-14 5:56 ` Tony Lindgren 2013-06-14 21:28 ` Pavel Machek 2013-06-14 21:28 ` Pavel Machek 2013-06-17 11:10 ` Tony Lindgren 2013-06-17 11:10 ` Tony Lindgren 2013-06-27 12:12 ` N900 device tree conversion: next steps Pavel Machek 2013-07-01 14:03 ` Pavel Machek [this message] 2013-07-01 14:03 ` [PATCH] N900: fix operation on emulator Pavel Machek 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 19:51 ` Pavel Machek 2013-07-01 19:51 ` Pavel Machek 2013-07-01 20:00 ` Sergei Shtylyov 2013-07-01 20:00 ` Sergei Shtylyov 2013-07-01 20:53 ` Pavel Machek 2013-07-01 20:53 ` Pavel Machek 2013-07-01 21:15 ` [PATCH] N900: enable N900-specific drivers even if device tree is enabled Pavel Machek 2013-07-01 21:15 ` Pavel Machek 2013-07-04 11:47 ` Tony Lindgren 2013-07-04 11:47 ` Tony Lindgren 2013-07-01 21:17 ` [PATCH] N900: add device tree Pavel Machek 2013-07-01 21:17 ` Pavel Machek 2013-07-04 17:19 ` Aaro Koskinen 2013-07-04 17:19 ` Aaro Koskinen 2013-07-04 20:21 ` Pavel Machek 2013-07-04 20:21 ` Pavel Machek 2013-07-04 20:32 ` Aaro Koskinen 2013-07-04 20:32 ` Aaro Koskinen 2013-07-13 12:17 ` [PATCH v2] " Pavel Machek 2013-07-13 12:17 ` Pavel Machek 2013-07-14 22:28 ` Aaro Koskinen 2013-07-14 22:28 ` Aaro Koskinen 2013-07-28 13:44 ` Pavel Machek 2013-07-28 13:44 ` Pavel Machek 2013-08-01 23:43 ` Pavel Machek 2013-08-01 23:43 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:27 ` [PATCH] ARM: dts: omap3 / n900 support, Benoit please take me (was Re: [PATCH v2] N900: add device tree) Pavel Machek 2013-08-10 11:27 ` Pavel Machek 2013-08-10 11:46 ` [PATCH v2] N900: add device tree Belisko Marek 2013-08-10 11:46 ` Belisko Marek 2013-08-10 20:29 ` Jiri Kosina 2013-08-10 20:29 ` Jiri Kosina 2013-08-11 0:55 ` OMAP device tree maintainance (was Re: [PATCH v2] N900: add device tree) Pavel Machek 2013-08-11 0:55 ` Pavel Machek 2013-08-11 11:50 ` [PATCH v2] N900: add device tree Javier Martinez Canillas 2013-08-11 11:50 ` Javier Martinez Canillas 2013-08-11 13:47 ` Pavel Machek 2013-08-11 13:47 ` Pavel Machek 2013-08-11 13:47 ` Pavel Machek 2013-08-12 7:37 ` Tony Lindgren 2013-08-12 7:37 ` Tony Lindgren 2013-08-12 7:36 ` Tony Lindgren 2013-08-12 7:36 ` Tony Lindgren 2013-08-11 15:02 ` Javier Martinez Canillas 2013-08-11 15:02 ` Javier Martinez Canillas 2013-08-13 10:50 ` Benoit Cousson 2013-08-13 10:50 ` Benoit Cousson 2013-08-13 13:36 ` [PATCH v3] " Pavel Machek 2013-08-13 13:36 ` Pavel Machek 2013-08-13 14:06 ` Benoit Cousson 2013-08-13 14:06 ` Benoit Cousson 2013-06-26 15:14 ` N900 device tree conversion: first step Pavel Machek 2013-07-19 18:14 ` N900 device tree conversion: how to do " Sebastian Reichel 2013-07-19 18:14 ` Sebastian Reichel 2013-07-19 18:14 ` Sebastian Reichel 2013-07-28 13:37 ` Pavel Machek 2013-07-28 13:37 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130701140315.GA15318@amd.pavel.ucw.cz \ --to=pavel@ucw.cz \ --cc=aaro.koskinen@iki.fi \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=pali.rohar@gmail.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.