On Tue, Jul 02, 2013 at 04:25:19PM +0100, Burton, Ross wrote:
> On 1 July 2013 14:57, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> > +do_install() {
> > +    # Only install file if it has a contents
> > +    if [ -s ${S}/pointercal.xinput ]; then
> > +        install -d ${D}${sysconfdir}/
> > +        install -m 0644 ${S}/pointercal.xinput ${D}${sysconfdir}/
> > +    fi
> > +}
> 
> The file always has content because the file in the main recipe has a
> comment in.  Personally I think not installing a useless file is the
> right thing to do, so we should change the default pointercal.xinput
> to be empty.
> 
> Relatedly, interestingly Weston has a different approach and attaches
> the calibration to the device using udev properties, which means
> systems where touch devices can be hotplugged actually work.  I'm
> incredibly tempted to extend xinput-calibrator to write out udev
> fragments and make Xi respect them if they exist...
> 
> > +++ b/meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb
> > +inherit autotools systemd
> 
> systemd?
> 
> > +RPROVIDES_${PN} += "${PN}-systemd"
> > +RREPLACES_${PN} += "${PN}-systemd"
> > +RCONFLICTS_${PN} += "${PN}-systemd"
> 
> It doesn't anymore, so these can be dropped.

That means that xinput-calibrator-systemd will stay installed on devices
which already have it.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com