From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuORn-00023T-4e for qemu-devel@nongnu.org; Wed, 03 Jul 2013 10:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuORl-0007su-I0 for qemu-devel@nongnu.org; Wed, 03 Jul 2013 10:54:19 -0400 Date: Wed, 3 Jul 2013 10:54:12 -0400 From: Luiz Capitulino Message-ID: <20130703105412.67a4a276@redhat.com> In-Reply-To: <1372342930-28684-2-git-send-email-armbru@redhat.com> References: <1372342930-28684-1-git-send-email-armbru@redhat.com> <1372342930-28684-2-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, kraxel@redhat.com On Thu, 27 Jun 2013 16:22:07 +0200 Markus Armbruster wrote: > Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" > assertion. Broken in commit 1da48c65. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Markus Armbruster Applied to the qmp branch, thanks. > --- > qemu-char.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 63972ae..63a9221 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3108,7 +3108,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts, ChardevBackend *backend, > > backend->memory = g_new0(ChardevMemory, 1); > > - val = qemu_opt_get_number(opts, "size", 0); > + val = qemu_opt_get_size(opts, "size", 0); > if (val != 0) { > backend->memory->has_size = true; > backend->memory->size = val;