From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756327Ab3GCN7p (ORCPT ); Wed, 3 Jul 2013 09:59:45 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:51737 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851Ab3GCN7n (ORCPT ); Wed, 3 Jul 2013 09:59:43 -0400 Date: Wed, 3 Jul 2013 15:59:33 +0200 From: Michael Holzheu To: Vivek Goyal Cc: HATAYAMA Daisuke , Jan Willeke , Martin Schwidefsky , Heiko Carstens , linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range() Message-ID: <20130703155933.3f3de4b9@holzheu> In-Reply-To: <20130702154214.GC22603@redhat.com> References: <1372707159-10425-1-git-send-email-holzheu@linux.vnet.ibm.com> <1372707159-10425-4-git-send-email-holzheu@linux.vnet.ibm.com> <20130702154214.GC22603@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13070313-6892-0000-0000-00000596C2D0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal wrote: > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: [snip] > > This handler works as follows: > > > > * Get already available or new page from page cache (find_or_create_page) > > * Check if /proc/vmcore page is filled with data (PageUptodate) > > * If yes: > > Return that page > > * If no: > > Fill page using __vmcore_read(), set PageUptodate, and return page > > > > Signed-off-by: Michael Holzheu > > In general vmcore related changes look fine to me. I am not very familiar > with the logic of finding pages in page cache and using page uptodate > flag. > > Hatayama, can you please review it. > > Acked-by: Vivek Goyal Hello Vivek, If Hatayama accepts the patch, should we then send the patch series to Andrew Morton? Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from e06smtp11.uk.ibm.com ([195.75.94.107]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UuNbo-0007FD-2a for kexec@lists.infradead.org; Wed, 03 Jul 2013 14:00:38 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Jul 2013 14:54:10 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id C33051B08023 for ; Wed, 3 Jul 2013 14:59:36 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r63DxP1f53477572 for ; Wed, 3 Jul 2013 13:59:25 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r63DxZXU018771 for ; Wed, 3 Jul 2013 07:59:35 -0600 Date: Wed, 3 Jul 2013 15:59:33 +0200 From: Michael Holzheu Subject: Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range() Message-ID: <20130703155933.3f3de4b9@holzheu> In-Reply-To: <20130702154214.GC22603@redhat.com> References: <1372707159-10425-1-git-send-email-holzheu@linux.vnet.ibm.com> <1372707159-10425-4-git-send-email-holzheu@linux.vnet.ibm.com> <20130702154214.GC22603@redhat.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Vivek Goyal Cc: Heiko Carstens , kexec@lists.infradead.org, Jan Willeke , linux-kernel@vger.kernel.org, HATAYAMA Daisuke , Martin Schwidefsky On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal wrote: > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: [snip] > > This handler works as follows: > > > > * Get already available or new page from page cache (find_or_create_page) > > * Check if /proc/vmcore page is filled with data (PageUptodate) > > * If yes: > > Return that page > > * If no: > > Fill page using __vmcore_read(), set PageUptodate, and return page > > > > Signed-off-by: Michael Holzheu > > In general vmcore related changes look fine to me. I am not very familiar > with the logic of finding pages in page cache and using page uptodate > flag. > > Hatayama, can you please review it. > > Acked-by: Vivek Goyal Hello Vivek, If Hatayama accepts the patch, should we then send the patch series to Andrew Morton? Michael _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec