From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Balaji T K <balajitk@ti.com>
Cc: a-bindra@ti.com, linux-mmc@vger.kernel.org, cjb@laptop.org,
linux-omap@vger.kernel.org, balbi@ti.com, nm@ti.com
Subject: Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well
Date: Sun, 7 Jul 2013 17:13:10 -0300 [thread overview]
Message-ID: <20130707201309.GA5429@localhost> (raw)
In-Reply-To: <51CDB260.8080108@ti.com>
Hi guys,
On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote:
> On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote:
> > From: Amarinder Bindra <a-bindra@ti.com>
> >
> > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation.
> > Considering that the device tree entries are already there for this,
> > allow the driver to be built when only OMAP5 is enabled.
> > This allows MMC root filesystems to be available in "OMAP5 only"
> > configurations.
> >
> > Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > Acked-by: Nishanth Menon <nm@ti.com>
>
> Looks good to me,
> Acked-by: Balaji T K <balajitk@ti.com>
>
I came across this same issue while trying MMC patches on AM3xx,
which is nor OMAP3 neither OMAP4.
Now, looking at the driver I don't see any OMAP-specific bits
(welcome to the multiplatform world ;-) so I think we can just
remove the 'depends' line. Something like this:
---
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 9ab8f8d..bade7f2 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -273,10 +273,9 @@ config MMC_OMAP
config MMC_OMAP_HS
tristate "TI OMAP High Speed Multimedia Card Interface support"
- depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4
help
This selects the TI OMAP High Speed Multimedia card Interface.
- If you have an OMAP2430 or OMAP3 board or OMAP4 board with a
+ If you have an OMAP2430, OMAP3, OMAP4 or AM3xx board with a
Multimedia Card slot, say Y or M here.
If unsure, say N.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-07 20:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 12:34 [PATCH] mmc: omap_hsmmc: use for OMAP5 as well a-bindra
2013-06-28 15:57 ` Balaji T K
2013-07-07 20:13 ` Ezequiel Garcia [this message]
2013-07-08 7:46 ` Felipe Balbi
2013-07-08 19:58 ` Nishanth Menon
2013-07-08 20:27 ` Ezequiel Garcia
2013-07-09 6:55 ` Felipe Balbi
2013-07-09 6:52 ` Felipe Balbi
2013-07-10 16:06 ` [PATCH v2] mmc: omap_hsmmc: use the generic config for omap2plus devices a-bindra
2013-07-10 21:13 ` Nishanth Menon
2013-07-10 22:42 ` Ezequiel Garcia
2013-07-11 13:09 ` Felipe Balbi
2013-08-16 16:35 ` Balaji T K
2013-08-25 19:51 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707201309.GA5429@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=a-bindra@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.