From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 18/18] PVH xen: introduce vmx_pvh.c
Date: Mon, 8 Jul 2013 16:09:55 -0700
Message-ID: <20130708160955.64bd62fb@mantra.us.oracle.com>
References: <1372118507-16864-1-git-send-email-mukesh.rathor@oracle.com>
	<1372118507-16864-19-git-send-email-mukesh.rathor@oracle.com>
	<51C991F502000078000E04E5@nat28.tlf.novell.com>
	<20130627183501.25bafddd@mantra.us.oracle.com>
	<51CD742902000078000E17D0@nat28.tlf.novell.com>
	<20130705183124.32d043f5@mantra.us.oracle.com>
	<51DA94F502000078000E328E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51DA94F502000078000E328E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 08 Jul 2013 09:31:17 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 06.07.13 at 03:31, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > Ok, lmk if you are ok with following:
> 
> Fundamentally yes. But ...
> 
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -41,6 +41,7 @@ obj-y += numa.o
> >  obj-y += pci.o
> >  obj-y += percpu.o
> >  obj-y += physdev.o
> > +obj-y += pvh.o
> 
> Does this indeed warrant a separate file?

yeah, i wasn't sure about that, but was not sure where to put it. I
think we could just have hvm_kernel_mode() next to
hvm_get_segment_register in hvm.h. It can then also be used in HVM code
in various places where it currently checks for dpl/cpl.


thanks
Mukesh