From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915/hsw: Expose resource streamer control flags Date: Tue, 9 Jul 2013 10:04:36 +0100 Message-ID: <20130709090436.GB14388@cantiga.alporthouse.com> References: <1373290729-18887-1-git-send-email-abdiel.janulgue@linux.intel.com> <1373290729-18887-2-git-send-email-abdiel.janulgue@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (unknown [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id A5300E5CFC for ; Tue, 9 Jul 2013 02:04:40 -0700 (PDT) Received: from fireflyinternet.com (unverified [87.106.93.118]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 129481544-1500050 for ; Tue, 09 Jul 2013 10:04:37 +0100 Content-Disposition: inline In-Reply-To: <1373290729-18887-2-git-send-email-abdiel.janulgue@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Abdiel Janulgue Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jul 08, 2013 at 04:38:48PM +0300, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 ++ > include/uapi/drm/i915_drm.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > index 5aeb447..3d6d3c9 100644 > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > @@ -865,6 +865,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, > } > if (args->flags & I915_EXEC_IS_PINNED) > flags |= I915_DISPATCH_PINNED; > + if (args->flags & I915_EXEC_RS) > + flags |= I915_EXEC_RS; Keep EXEC and DISPATCH as distinct namespaces. > switch (args->flags & I915_EXEC_RING_MASK) { > case I915_EXEC_DEFAULT: > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index 923ed7f..728f544 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -661,6 +661,7 @@ struct drm_i915_gem_execbuffer2 { > #define I915_EXEC_BSD (2<<0) > #define I915_EXEC_BLT (3<<0) > #define I915_EXEC_VEBOX (4<<0) > +#define I915_EXEC_RS (8<<0) This is in the portion of bits set aside for new rings. Please add it to the end of the of the flags. And call it _RESOURCE_STREAMER to be less ambiguous. -Chris -- Chris Wilson, Intel Open Source Technology Centre