From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899Ab3GJJhC (ORCPT ); Wed, 10 Jul 2013 05:37:02 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620Ab3GJJhA (ORCPT ); Wed, 10 Jul 2013 05:37:00 -0400 Date: Wed, 10 Jul 2013 11:36:42 +0200 From: Borislav Petkov To: Geert Uytterhoeven Cc: Kyungsik Lee , Andrew Morton , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild , the arch/x86 maintainers , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Florian Fainelli , Yann Collet , Chanho Min , Linux-Next , "uclinux-dist-devel@blackfin.uclinux.org" Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130710093642.GC14873@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index a0ab6d7..c9bfbb0 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ > >> > >> quiet_cmd_lz4 = LZ4 $@ > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > > > You probably want to check for the presence of lz4c on the system and > > bail with an informative message if absent. > > Yep, x86_64-randconfig > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): > > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 > /bin/sh: lz4c: command not found Sure, it had to be 2 months and to hit upstream for there still to be no fix. Geez... Anyone reading this and willing to try his skills with an introductory-level patch, feel free to address this. I'll help testing and upstreaming it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([78.46.96.112]:34186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620Ab3GJJhA (ORCPT ); Wed, 10 Jul 2013 05:37:00 -0400 Date: Wed, 10 Jul 2013 11:36:42 +0200 From: Borislav Petkov Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130710093642.GC14873@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Kyungsik Lee , Andrew Morton , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild , the arch/x86 maintainers , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Florian Fainelli , Yann Collet , Chanho Min , Linux-Next , "uclinux-dist-devel@blackfin.uclinux.org" On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index a0ab6d7..c9bfbb0 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ > >> > >> quiet_cmd_lz4 = LZ4 $@ > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > > > You probably want to check for the presence of lz4c on the system and > > bail with an informative message if absent. > > Yep, x86_64-randconfig > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): > > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 > /bin/sh: lz4c: command not found Sure, it had to be 2 months and to hit upstream for there still to be no fix. Geez... Anyone reading this and willing to try his skills with an introductory-level patch, feel free to address this. I'll help testing and upstreaming it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Wed, 10 Jul 2013 11:36:42 +0200 Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format In-Reply-To: References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> Message-ID: <20130710093642.GC14873@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index a0ab6d7..c9bfbb0 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ > >> > >> quiet_cmd_lz4 = LZ4 $@ > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > > > You probably want to check for the presence of lz4c on the system and > > bail with an informative message if absent. > > Yep, x86_64-randconfig > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): > > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 > /bin/sh: lz4c: command not found Sure, it had to be 2 months and to hit upstream for there still to be no fix. Geez... Anyone reading this and willing to try his skills with an introductory-level patch, feel free to address this. I'll help testing and upstreaming it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --