From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws1K-000589-PQ for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uws1H-0002ru-GU for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:53:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws1H-0002rh-92 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:53:11 -0400 Date: Wed, 10 Jul 2013 18:52:57 +0800 From: Fam Zheng Message-ID: <20130710105257.GD18465@T430s.nay.redhat.com> References: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> <1373268366-14508-4-git-send-email-cngesaint@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373268366-14508-4-git-send-email-cngesaint@gmail.com> Subject: Re: [Qemu-devel] [PATCH V2 3/5] Check infinite loop in bdrv_img_create() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com On Mon, 07/08 03:26, Xu Wang wrote: > Signed-off-by: Xu Wang > --- > block.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/block.c b/block.c > index 8dc6ded..6df25d9 100644 > --- a/block.c > +++ b/block.c > @@ -4688,15 +4688,15 @@ void bdrv_img_create(const char *filename, const char *fmt, > } > > backing_file = get_option_parameter(param, BLOCK_OPT_BACKING_FILE); > + backing_fmt = get_option_parameter(param, BLOCK_OPT_BACKING_FMT); > if (backing_file && backing_file->value.s) { > - if (!strcmp(filename, backing_file->value.s)) { > - error_setg(errp, "Error: Trying to create an image with the " > - "same filename as the backing file"); > + if (bdrv_backing_file_loop_check(filename, fmt, true, > + backing_file->value.s, Trailing whitespace. > + backing_fmt->value.s)) { > + /* There is loop exists in the backing file chain */ I see why you pass both filename and backing_file to in now, filename is not created yet so bdrv_get_backing_filename is not usable, but it needs to be checked. -- Fam