From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws5e-00081C-A2 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uws5a-0004Ob-T9 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:57:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uws5a-0004OW-Kq for qemu-devel@nongnu.org; Wed, 10 Jul 2013 06:57:38 -0400 Date: Wed, 10 Jul 2013 18:57:13 +0800 From: Fam Zheng Message-ID: <20130710105713.GE18465@T430s.nay.redhat.com> References: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> <1373268366-14508-5-git-send-email-cngesaint@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373268366-14508-5-git-send-email-cngesaint@gmail.com> Subject: Re: [Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com On Mon, 07/08 03:26, Xu Wang wrote: > Signed-off-by: Xu Wang > --- > block.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/block.c b/block.c > index 6df25d9..379b79b 100644 > --- a/block.c > +++ b/block.c > @@ -1971,6 +1971,12 @@ int bdrv_change_backing_file(BlockDriverState *bs, > return -EINVAL; > } > > + /* Check if loop exists in backing files chain after changed */ > + if (bdrv_backing_file_loop_check(bs->filename, NULL, true, backing_file, You can use bs->drv->format_name for fmt. > + backing_fmt)) { > + return -EIO; > + } > + > if (drv->bdrv_change_backing_file != NULL) { > ret = drv->bdrv_change_backing_file(bs, backing_file, backing_fmt); > } else { > -- > 1.8.1.4 > > -- Fam